Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single click in file dialog enters two directories #5053

Closed
2 tasks done
codesoap opened this issue Aug 5, 2024 · 8 comments
Closed
2 tasks done

Single click in file dialog enters two directories #5053

codesoap opened this issue Aug 5, 2024 · 8 comments
Assignees
Labels
blocker Items that would block a forthcoming release bug Something isn't working FileDialog Improvements to the builtin file dialogs

Comments

@codesoap
Copy link
Contributor

codesoap commented Aug 5, 2024

Checklist

  • I have searched the issue tracker for open issues that relate to the same problem, before opening a new one.
  • This issue only relates to a single bug. I will open new issues for any other problems.

Describe the bug

When clicking a directory in a file dialog, the dialog will go two directories deeper instead of one, whenever possible.

This has been reported to me by a @vaibhav-kaushal: codesoap/spind#1

How to reproduce

  1. Run go run fyne.io/fyne/v2/cmd/[email protected].
  2. Go to the "Dialogs" tab.
  3. Click "Folder Open".
  4. Now click a directory which also contains a directory "at the same position"; this means if the first directory is, e.g., the third entry, this directory should also contain another directory as its third entry.

In case I didn't explain 4. well enough, here is an example: Create mkdir -p /tmp/foo/bar/baz, then go to /tmp/foo with the file dialog and click "bar". Instead of just changing directory to "bar", fyne will directly go to "bar/baz".

Screenshots

No response

Example code

go run fyne.io/fyne/v2/cmd/[email protected]

Fyne version

54b25af

Go compiler version

go version go1.22.1 openbsd/amd64

Operating system and version

OpenBSD 7.5

Additional Information

git bisect shows me that 54b25af introduced the bug.

@codesoap codesoap added the unverified A bug that has been reported but not verified label Aug 5, 2024
@hfmrow
Copy link

hfmrow commented Aug 12, 2024

Hi,
I can confirm this issue. I'm using W10, Fyne v2.5, Go 1.22.6 and I've had to create my own file explorer to work around this issue. I've also tested it on Android and, since the file explorer uses the native Android version, the problem doesn't occur there.

openFolderIssue

Walk through some dir...

@andydotxyz andydotxyz added bug Something isn't working FileDialog Improvements to the builtin file dialogs and removed unverified A bug that has been reported but not verified labels Aug 12, 2024
@andydotxyz
Copy link
Member

Yes I have started to see this as well. Let's try and get it fixed ASAP

@andydotxyz andydotxyz added this to the E fixes (v2.5.x) milestone Aug 12, 2024
@hfmrow
Copy link

hfmrow commented Aug 12, 2024

Yes I have started to see this as well. Let's try and get it fixed ASAP

I hadn't noticed that, thank you for pointing it out to me.

@andydotxyz
Copy link
Member

I have a fix ready, just want to get some tests in and I'll open a PR. We will get this fixed in 2.5.1.

@andydotxyz andydotxyz self-assigned this Aug 12, 2024
@andydotxyz andydotxyz added the blocker Items that would block a forthcoming release label Aug 12, 2024
@andydotxyz
Copy link
Member

Adding blocker as this is a pretty bad regression.

andydotxyz added a commit to andydotxyz/fyne that referenced this issue Aug 12, 2024
Looks like a bad merge in 2.5.0 prep
Fixes fyne-io#5053
@hfmrow
Copy link

hfmrow commented Aug 13, 2024

@andydotxyz Thank you.

@andydotxyz
Copy link
Member

Fixed landed ready for v2.5.1

@codesoap
Copy link
Contributor Author

Thanks!

andydotxyz added a commit to andydotxyz/fyne that referenced this issue Aug 15, 2024
Looks like a bad merge in 2.5.0 prep
Fixes fyne-io#5053
codesoap added a commit to codesoap/spind that referenced this issue Aug 28, 2024
The new version fixes a bug where one click would enter two directories
in the file dialogs. See fyne-io/fyne#5053.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker Items that would block a forthcoming release bug Something isn't working FileDialog Improvements to the builtin file dialogs
Projects
None yet
Development

No branches or pull requests

3 participants