Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add a way to embed the FyneApp.toml metadata into the go build. #4688

Closed
2 tasks done
mondy opened this issue Mar 1, 2024 · 2 comments
Closed
2 tasks done

Comments

@mondy
Copy link

mondy commented Mar 1, 2024

Checklist

  • I have searched the issue tracker for open issues that relate to the same feature, before opening a new one.
  • This issue only relates to a single feature. I will open new issues for any other features.

Is your feature request related to a problem?

Simply put, I want to disable -H=windowsgui and embed the FyneApp.toml metadata.
See #3781 and #3604.

The option to disable -H=windowsgui in fyne build was not accepted.
However, if there is a way to add metadata when go build, the problem is solved.

Is it possible to construct a solution with the existing API?

No response

Describe the solution you'd like to see.

Add a new subcommand to the fyne command to generate metadata source code.
The source code to set the metadata is generated at fyne build time.
The source code for the following section will be helpful.

https://github.com/fyne-io/fyne/blob/e332a5e47813bff1af9631cbbfe84654c0143189/cmd/fyne/internal/commands/build.go#L377C6-L377C28

Or maybe there is a better way. Is there anything?

andydotxyz added a commit to andydotxyz/fyne that referenced this issue Mar 11, 2024
This means we can just 'go run .' and get icons etc.
Fixes fyne-io#4688
@andydotxyz
Copy link
Member

As you can see in the PR #4715 I realised that it should be possible to do this completely transparently so that when you run using standard Go tools we pick up metadata if present.

@andydotxyz
Copy link
Member

From v2.5.0 this will just work by default :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants