Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New 2.3.0 theme suggestions #3462

Closed
2 tasks done
matwachich opened this issue Dec 7, 2022 · 5 comments
Closed
2 tasks done

New 2.3.0 theme suggestions #3462

matwachich opened this issue Dec 7, 2022 · 5 comments
Labels
Design Requires some visual design process

Comments

@matwachich
Copy link
Contributor

Checklist

  • I have searched the issue tracker for open issues that relate to the same feature, before opening a new one.
  • This issue only relates to a single feature. I will open new issues for any other features.

Is your feature request related to a problem?

There are some little things that I think should be improved in the new theme:

Check mark should be white
image

Menu items and buttons should have a little more right-padding to by symmetrical
image
image

Is it possible to construct a solution with the existing API?

No response

Describe the solution you'd like to see.

image

@Jacalz Jacalz added the Design Requires some visual design process label Dec 8, 2022
@Jacalz Jacalz added this to the Cragganmore Release (v2.3) milestone Dec 8, 2022
@andydotxyz
Copy link
Member

andydotxyz commented Dec 8, 2022

After discussion we agreed the button padding is correct. Let's update:

  • Contrast on checked box
  • Padding on right of menu items

@Jacalz Jacalz added the blocker Items that would block a forthcoming release label Dec 9, 2022
@andydotxyz
Copy link
Member

Fixes for the issue listed all on the PR linked, we will add another rc once this is in

@matwachich
Copy link
Contributor Author

Another one
image

@Jacalz Jacalz removed the blocker Items that would block a forthcoming release label Dec 12, 2022
@Jacalz
Copy link
Member

Jacalz commented Dec 12, 2022

I wonder, should we perhaps improve how the focused high importance button looks?
image

@andydotxyz
Copy link
Member

That's all the items we discussed landed on latest release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design Requires some visual design process
Projects
None yet
Development

No branches or pull requests

3 participants