Negative TableCellID Row

[Aj5y8HBIFf]

Describe the bug:

I get a negative TableCellID Row when table is too wide (?).

The bug seems to be due to this line

fyne/widget/table.go

Line 640 in 7229e88

offY := r.cells.t.offset.Y - float32(int(r.cells.t.offset.Y)%int(r.cells.cellSize.Height+separatorThickness))

r.cells.t.offset.Y is negative for some reason.

Adding the following code fixes the issue:

if r.cells.t.offset.Y < 0 {
	r.cells.t.offset.Y = 0
}

panic: runtime error: index out of range [-3]

goroutine 50 [running]:
main.main.func3({0xc000108270?, 0xc042a01800?}, {0x4470d78?, 0xc000108270?})
        /Users/xxx/Documents/project/cmd/test1/main.go:24 +0xa5
fyne.io/fyne/v2/widget.(*tableCellsRenderer).Refresh(0xc0000b4240)
        /Users/xxx/Documents/project/vendor/fyne.io/fyne/v2/widget/table.go:673 +0x691
fyne.io/fyne/v2/widget.(*BaseWidget).Refresh(0xc0000ba000?)
        /Users/xxx/Documents/project/vendor/fyne.io/fyne/v2/widget/widget.go:138 +0x2e
fyne.io/fyne/v2/widget.(*Table).finishScroll(0xc0003c0820)
        /Users/xxx/Documents/project/vendor/fyne.io/fyne/v2/widget/table.go:289 +0x4e
fyne.io/fyne/v2/widget.(*Table).ScrollToBottom(0xc0003c0820)
        /Users/xxx/Documents/project/vendor/fyne.io/fyne/v2/widget/table.go:215 +0x9f
main.main.func4()
        /Users/xxx/Documents/project/cmd/test1/main.go:33 +0x149
created by main.main
        /Users/xxx/Documents/project/cmd/test1/main.go:30 +0x319

Process finished with the exit code 2

To Reproduce:

Steps to reproduce the behaviour:

1. Run the below script

Example code:

package main

import (
	"fyne.io/fyne/v2"
	"fyne.io/fyne/v2/app"
	"fyne.io/fyne/v2/container"
	"fyne.io/fyne/v2/layout"
	"fyne.io/fyne/v2/widget"
	"strconv"
	"time"
)

func main() {
	a := app.New()
	w := a.NewWindow("Some title")

	tableData := make([][]string, 0)
	table := widget.NewTable(func() (int, int) { return len(tableData), 3 },
		func() fyne.CanvasObject {
			item := widget.NewLabel("template")
			return item
		},
		func(i widget.TableCellID, o fyne.CanvasObject) {
			o.(*widget.Label).SetText(tableData[i.Row][i.Col])
		})
	table.SetColumnWidth(0, 40)
	table.SetColumnWidth(1, 80)
	table.SetColumnWidth(2, 80)

	go func() {
		time.Sleep(3 * time.Second)
		tableData = append(tableData, []string{strconv.Itoa(len(tableData) + 1), "test1", "test2"})
		table.ScrollToBottom()
	}()

	c := container.New(layout.NewMaxLayout(), table)

	w.SetContent(c)
	w.Resize(fyne.NewSize(300, 200))
	w.ShowAndRun()
}

Device (please complete the following information):

• OS: MacOS
• Version: 12.1 Monterey
• Go version: 1.18
• Fyne version: 2.1.4

[lisx123]

cool bro,thanks

[andydotxyz]

Fixed on develop and release branch for 2.3.5