Merge pull request #5115 from williambrode/issue-5114

Avoid deadlock in button renderer by aquiring read lock twice.
fyne-io · Sep 5, 2024 · 367ea0a · 367ea0a
2 parents 5fb3d75 + 110aba7
commit 367ea0a
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/widget/button.go b/widget/button.go
@@ -393,7 +393,7 @@ func (r *buttonRenderer) padding(th fyne.Theme) fyne.Size {
 
 // must be called with r.button.propertyLock RLocked
 func (r *buttonRenderer) updateIconAndText() {
-	if r.button.Icon != nil && r.button.Visible() {
+	if r.button.Icon != nil && !r.button.Hidden {
 		icon := r.button.Icon
 		if r.icon == nil {
 			r.icon = canvas.NewImageFromResource(icon)