Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo build doesn't always pick up changes in components/ crates #424

Closed
fabricedesre opened this issue Apr 25, 2016 · 3 comments
Closed
Labels

Comments

@fabricedesre
Copy link
Collaborator

STR:

  • Do a full build with cargo build
  • Introduce obvious syntax error in components/dnschallenge/mains.rs
  • Run cargo build again.

Expected:

  • We rebuild dnschallenge and foxbox.

Observed:

  • We don't rebuild anything, so we have to run cargo clean first, and clobber the main foxbox crate.

I'm not sure if we can do everything we need in something driven by cargo or if we need to go the mach route like servo (that would make me a bit sad).

ping @JohanLorenzo @samgiles

@JohanLorenzo
Copy link
Contributor

I think this is caused by build.rs not being called because cargo didn't notice a file has changed. It doesn't occur with a library stored under components/.

I think we can solve it by either a Makefile/mach or making dns_challenge both a library and a binary. This library would be declared in the root Cargo.toml so it can detect any of its changes. What do you think @samgiles ?

@fabricedesre
Copy link
Collaborator Author

Or we could maybe fix cargo to understand this kind of setup.

@ferjm ferjm added the Build label Apr 26, 2016
julienw added a commit to julienw/foxbox that referenced this issue Apr 27, 2016

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…, fxbox#424)
julienw added a commit to julienw/foxbox that referenced this issue Apr 28, 2016
julienw added a commit to julienw/foxbox that referenced this issue Apr 28, 2016
julienw added a commit that referenced this issue Apr 28, 2016
)

This also adds a run.sh script to easily run foxbox
@julienw
Copy link
Contributor

julienw commented Apr 28, 2016

should be fixed by ecc92fa

@julienw julienw closed this as completed Apr 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants