Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrapping cargo with mach, the command dispatcher #18

Closed
wants to merge 1 commit into from
Closed

Wrapping cargo with mach, the command dispatcher #18

wants to merge 1 commit into from

Conversation

@fabricedesre
Copy link

I think we'll have to do it - likely copying as much as we can from servo. They even install the right rustc version locally to have something very self contained.

@samgiles
Copy link

samgiles commented Jun 9, 2016

I'm in favour of this generally. I haven't looked at Servo for a while - how much could we reuse/share, or has it ended up being very specific to Servo?

@julienw
Copy link

julienw commented Jun 9, 2016

I'd favor using the mach from servo as well (I haven't looked much closer). I don't like the idea of doing our own stuff. It was ok while run.sh was only 1 line but if we need more than this, let's use something existing.

But let's try to not depend on it too much, as maybe cargo will eventually evolve to support some of our issues. It's ok to depend on it to launch commands before/after building/testing, but for example I'm not so at ease with the idea of installing dependencies. (although I wouldn't block this)

@JohanLorenzo
Copy link
Contributor Author

There hasn't been any activity on this PR for more than 2 years. Although, I see some fxbox repos still have some activity. I'm closing this PR for the sake of cleanup. Please reopen if you think it still has some use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants