Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go: update go.mod and ci.yml to require go1.20 or newer (was go1.17) #626

Merged
merged 4 commits into from
Feb 22, 2025

Conversation

fxamacker
Copy link
Owner

@fxamacker fxamacker commented Feb 22, 2025

Changes:

[x] Update ci.yml to test latest 5 versions of go. This drops testing of go1.17-1.19 (needed by next PR) and adds go1.24.
[x] Bump go from 1.17 to 1.20 in go.mod
[x] Delete encode_map_go117.go
[x] Remove //go:build go1.20 from encode_map.go

Updates #625

Update ci.yml to test latest 5 versions of go.
@fxamacker fxamacker added this to the v2.8.0 milestone Feb 22, 2025
@fxamacker fxamacker self-assigned this Feb 22, 2025
@fxamacker fxamacker marked this pull request as draft February 22, 2025 18:22
@fxamacker fxamacker changed the title .github: update ci.yml to test go1.20-1.24 go: update go.mod and ci.yml to require go1.20 or newer (was go1.17) Feb 22, 2025
@fxamacker fxamacker marked this pull request as ready for review February 22, 2025 18:47
@fxamacker
Copy link
Owner Author

@x448 PTAL 🙏

Copy link
Contributor

@x448 x448 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fxamacker fxamacker merged commit 57985ad into master Feb 22, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants