Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump golangci-lint from 1.53.3 to 1.54.2 #543

Merged
merged 2 commits into from
May 28, 2024
Merged

Bump golangci-lint from 1.53.3 to 1.54.2 #543

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f928cfe
bump golangci-lint from 1.53.3 to 1.54.2
fxamacker May 28, 2024
3ffae58
Update .golangci.yml
fxamacker May 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/safer-golangci-lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@ on:

env:
GO_VERSION: '1.20'
GOLINTERS_VERSION: 1.53.3
GOLINTERS_VERSION: 1.54.2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not bump to 1.56.2?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not bump to 1.56.2?

I was already using 1.54.2 locally and it passed all lints including go-critic. Maybe newer version next weekend.

GOLINTERS_ARCH: linux-amd64
GOLINTERS_TGZ_DGST: 4f62007ca96372ccba54760e2ed39c2446b40ec24d9a90c21aad9f2fdf6cf0da
GOLINTERS_TGZ_DGST: 17c9ca05253efe833d47f38caf670aad2202b5e6515879a99873fabd4c7452b3
GOLINTERS_TIMEOUT: 15m
OPENSSL_DGST_CMD: openssl dgst -sha256 -r
CURL_CMD: curl --proto =https --tlsv1.2 --location --silent --show-error --fail
Expand Down
1 change: 1 addition & 0 deletions .golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ linters:
- errcheck
- exportloopref
- goconst
- gocritic
- gocyclo
- gofmt
- goimports
Expand Down
Loading