Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add decoding option TimeTagToAny to produce RFC3339 when decoding time into interface{} #506

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

ssuriyan7
Copy link
Contributor

Adds a decoding option to specify how to decode CBOR tag 0 or 1 data item into an empty interface.
Based on the specified mode, Unmarshal can return a time.Time value or a time string in a specific format.

Description

PR Was Proposed and Welcomed in Currently Open Issue

Checklist (for code PR only, ignore for docs PR)

  • Include unit tests that cover the new code
  • Pass all unit tests
  • Pass all lint checks in CI (goimports, gosec, staticcheck, etc.)
  • Sign each commit with your real name and email.
    Last line of each commit message should be in this format:
    Signed-off-by: Firstname Lastname [email protected]
  • Certify the Developer's Certificate of Origin 1.1
    (see next section).

Certify the Developer's Certificate of Origin 1.1

  • By marking this item as completed, I certify
    the Developer Certificate of Origin 1.1.
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
660 York Street, Suite 102,
San Francisco, CA 94110 USA

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@fxamacker
Copy link
Owner

@ssuriyan7 Thanks for opening this PR! I'll try to take a look this week/weekend. 🙏

Copy link
Owner

@fxamacker fxamacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ssuriyan7 Thanks for opening this PR! 👍

I left some suggestions to make this deterministic by preserving time zone. This will also simplify tests by eliminating the need to have tests deal with nondeterministic output.

decode.go Outdated Show resolved Hide resolved
decode_test.go Outdated Show resolved Hide resolved
Adds a decoding option to specify how to decode CBOR tag 0 or 1 data item into an empty interface.
Based on the specified mode, Unmarshal can return a time.Time value or a time string in a specific format.

Signed-off-by: Suriyan Subbarayan [email protected]
@ssuriyan7 ssuriyan7 force-pushed the rfc3339-timestring branch from a37e7c5 to 219a19c Compare March 30, 2024 02:15
@ssuriyan7
Copy link
Contributor Author

@fxamacker , Thanks for your suggestion. I've incorporated them. Please take a look.

@ssuriyan7 ssuriyan7 requested a review from fxamacker March 30, 2024 02:46
Copy link
Owner

@fxamacker fxamacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for contributing this PR!

@fxamacker fxamacker merged commit 3cec62b into fxamacker:master Apr 1, 2024
17 checks passed
@fxamacker fxamacker changed the title Add decoding option to specific how to decode tag 0 or 1 into any Add decoding option to specify how to decode tag 0 or 1 into any Apr 1, 2024
@fxamacker fxamacker added this to the v2.7.0 milestone Apr 22, 2024
@fxamacker fxamacker added the enhancement New feature or request label Apr 22, 2024
@fxamacker fxamacker changed the title Add decoding option to specify how to decode tag 0 or 1 into any Add decoding option TimeTagToAny to produce RFC3339 when decoding time into interface{} May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants