Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document behavior of Unmarshal of unrecognized tags into interface{} #448

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Document behavior of Unmarshal of unrecognized tags into interface{} #448

merged 1 commit into from
Dec 8, 2023

Conversation

benluddy
Copy link
Contributor

@benluddy benluddy commented Dec 7, 2023

Description

Updates the Unmarshal godoc to mention that unmarshaling into interface{} can produce cbor.Tag (#447).

fxamacker
fxamacker approved these changes Dec 8, 2023
View reviewed changes
Copy link
Owner

@fxamacker fxamacker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this and fixing it! 👍

@fxamacker fxamacker merged commit a1d4c29 into fxamacker:master Dec 8, 2023
17 checks passed
@fxamacker fxamacker mentioned this pull request Dec 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fxamacker fxamacker fxamacker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benluddy @fxamacker