Add Decoder.Buffered to return buffered data
#412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Buffered returns an io.Reader for data remaining in Decoder's buffer. The returned reader is valid until the next call to Decode or Skip. This basically matches the Decoder.Buffered() in Go's encoding/json.
6 tasks
x448
approved these changes
Jun 25, 2023
|
This is great, thank you for adding this! I think I'll close #397 for now and change our code to use Decoder.Buffered. If this comes up again in our profiling, I'll do the testing of "don't read ahead if the input reader supports efficient byte-at-a-time reading" and open a new PR if warranted. Thanks again for your work on maintaining this library! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Buffered returns an
io.Readerfor data remaining in Decoder's buffer. The returned reader is valid until the next call toDecodeorSkip.This basically matches
Decoder.Bufferedin Go's encoding/json.Thanks @immesys for discussions and insights at PR #397.