Retry in decoder if Read() returns 0 bytes read with nil error #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, decoder did not properly handle the scenario of Read() returning 0 bytes read with nil error. Fix this by retrying the read on (0, nil). While at it, also refactor the error handling code and add more tests for 100% code coverage for stream.go.
x448
reviewed
Feb 20, 2023
decode.go
Outdated
| @@ -570,10 +579,10 @@ type decoder struct { | |||
| } | |||
|
|
|||
| // value decodes CBOR data item into the value pointed to by v. | |||
| // If CBOR data item is invalid, error is returned and offset isn't changed. | |||
| // If CBOR data item is valid but fails to be decode into v for other reasons, | |||
| // If CBOR data item fails to be decode into v, | |||
There was a problem hiding this comment.
Nice work! Great to have 100% coverage in stream_test.go!
Didn't spot any problems in the code, but a comment has grammar error "fails to be decode into v".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
Decoderdid not properly handle the scenario ofReadimplementations returning 0 bytes read with nil error.Go docs for
io.ReaderdiscourageReadimplementations from returning 0 bytes with nil error. And callers should treat this as if nothing happened.This PR:
Readif it returns (0, nil).Closes #385 - thanks @mixmasala for reporting this issue.