Implement formatter and use embedded Kotlin compiler #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that no duplicate JARs are included in the runtime classpath of the language server.
Provide compatibility with 'ktlint' and temporarily drop J2K support.
Create a unit test which verifies that the formatter works as intended.
Formatting options determine the indentation size and style used by the formatter.
Use embedded Kotlin scripting JVM host.
Additionally, implement Closeable instead of AutoCloseable on classes which manage resources, so they can be used with Kotlin's 'use'-function.
This was referenced Aug 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27.
This PR integrates
ktlintas a formatter. Sincektlintuses the embedded compiler, which is incompatible with the standard compiler (different import paths:com.intellij.*vsorg.jetbrains.com.intellij.*), this PR also migrates this project's compiler dependency to the embedded version. Unfortunately, that breaks the Java-to-Kotlin converter.Possible solutions would include writing our own J2K, using AST visitors, or somehow adapting the import paths of the official converter.