-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to Swift 6 language mode #172
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
101e934
to
1177fd1
Compare
This is to avoid having the CairoImage cross isolation domains, which it cannot since it is not sendable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bumps the required Swift version to Swift 6, which introduces data race safety via strict concurrency checking. Consequently, a larger refactoring is required.
Useful Tricks
Sendable Closures
When encounting an error like this:
it has proven to be useful to mark the closure as
@Sendable
to get a better error message. After issues have been fixed, the annotation can be removed (for clarity/readability) since sendability can be inferred.Note
In cases where
@preconcurrency
imports are used, the same trick may have to be applied again once the libraries have been updated if the annotation is removed, since the closures may implicitly become non-sendable again.Shared Mutability
Classes with interior mutability are usually best modeled as actors.