Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Vue 3 Support #87

Open
wants to merge 25 commits into
base: next
Choose a base branch
from
Open

feat: Vue 3 Support #87

wants to merge 25 commits into from

Conversation

fuxingloh
Copy link
Owner

@fuxingloh fuxingloh commented Jan 23, 2021

Work in progress, long running pull request. Still require many other dependencies before vue 3 is ready.

Migration changes to note

  • 'responsive' is removed from Vue 3 version because CSS is not injected anymore.
    • You should be the one creating the CSS anyway.
    • This also means CSS is inlined thus reducing load inject style hydration UI shifting.
  • render() is used to construct the component now = < 1.8 KB compressed size. Hooray!
  • backwards compatible as of now and published in @next tag.

Goals

  • Baseline support for Vue 3, e2e tested
  • Update Documentations about Vue 3 Support
  • Setup basic workflow, CI for code quality
  • CSS inject into JS export a single file, not sure how to approach this yet, need to make it easy for users to use.
    • Could inline all the CSS, this would resolve other issues with JS injected CSS.
    • And move alway from template and construct the element via the render function
  • Move to Composition API (cross cutting concern, might not worth the time to migrate)
  • Publish as tag @next & v1 will be for Vue 3
  • Support RTS Arabic scripts
    • Conflicted over supporting this, might be easier to force lts and set rts on the inner elements
    • Whatever the decision, update the docs later.
  • Use dist version to test SSG & SSR
  • Migrate docs to use Vue 3 based SSG

Once Vue 3 is adopted by other framework such as Nuxt, merge next into main.

@cypress
Copy link

cypress bot commented Jan 23, 2021



Test summary

88 2 0 0


Run details

Project vue-horizontal
Status Failed
Commit 216f73a ℹ️
Started Oct 17, 2021 10:15 AM
Ended Oct 17, 2021 10:20 AM
Duration 05:11 💡
OS Windows 10.0.17763
Browser Edge 94

View run in Cypress Dashboard ➡️

Failures are unavailable for this run. For more information, see the Cypress Dashboard


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@github-actions
Copy link

github-actions bot commented Jan 24, 2021

size-limit report 📦

Path Size
dist/vue-horizontal.esm.js 0 B (-100% 🔽)
dist/vue-horizontal.min.js 0 B (-100% 🔽)
dist/vue-horizontal.ssr.js 0 B (-100% 🔽)
./dist/vue-horizontal.umd.js 1.73 KB (+100% 🔺)
./dist/vue-horizontal.es.js 1.74 KB (+100% 🔺)

@fuxingloh fuxingloh linked an issue Jan 26, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vue3 Support
1 participant