Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

different behavior between insert-note and insert-precise-note? #54

Open
rdiaz02 opened this issue Oct 14, 2020 · 3 comments
Open

different behavior between insert-note and insert-precise-note? #54

rdiaz02 opened this issue Oct 14, 2020 · 3 comments

Comments

@rdiaz02
Copy link
Contributor

rdiaz02 commented Oct 14, 2020

When using org-noter-pdftools I find no difference between i (org-noter-insert-note) and M-i (org-noter-insert-precise-note).

I find it counterintuitive that org-noter-insert-note asks the question You can click anywhere on the page to add a link to. Do you want to do that? : mimicking the behavior of org-noter's org-insert-note I was expecting that a link to the page, without further questions, be inserted in the org buffer. So I think I am misunderstanding something here.

@fuxialexander
Copy link
Owner

You can now set org-pdftools-use-isearch-link and org-pdftools-use-freestyle-annot to nil and use org-noter-pdftools-insert-precise-note for precise note and org-noter-insert-note otherwise.

fuxialexander added a commit that referenced this issue Jan 10, 2021
- Incorporated
weirdNox/org-noter@f8349ae
in Usage README
- Added customizable variable ~org-pdftools-use-isearch-link~ and
~org-pdftools-use-freepointer-annot~ to control whether you will get
prompt to create isearch/freepointer link if no existing annotations
are found

Addressed:
#60
#54
@rdiaz02
Copy link
Contributor Author

rdiaz02 commented Mar 3, 2021

Thanks. I think the variable is org-pdftools-use-freepointer-annot (not org-pdftools-use-freestyle-annot).

But still, I am confused (or something in my setup is wrong): when I set that variable to nil I am no longer asked any questions. But as far as I can see, all three of org-noter-pdftools-insert-precise-note, org-noter-insert-note, and org-noter-insert-precise-note behave identically (and no longer is a symbol inserted anywhere in the PDF to mark the location).

If I set org-pdftools-use-freepointer-annot to true then I am always asked questions (with the three of them), and they all behave identically (and a symbol is placed in the place I click).

If I mark text in the pdf, and then call each function, also the three functions behave similarly (they never ask for the location, regardless of the setting of org-pdftools-use-freepointer-annot).

As I said, I guess I am confused. I see no way to directly insert some note with arbitrary text that will allow to point to a precise location (asking me for the location) when I use insert-precise-note and to add a note just to a page, without asking for the location, when I use insert-note.

But I can just mark text in the PDF and press TAB (or i) and I get the text in the notes buffer, and if I click on it, I am brought to the location in the PDF, which is awesome. And I can add arbitrary text then.

I don't think any of this is worth your trouble, so I guess we can close this.

@duzaichuan
Copy link

org-noter-pdftools-insert-precise-note works as expected if org-pdftools-use-freestyle-annot is modified to org-pdftools-use-freepointer-annot in the definition of function org-noter-pdftools-insert-precise-note. There is no such a variable org-pdftools-use-freestyle-annot . I think "freestyle" might be a typo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants