Mitigate linker error from Rust compiler #123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WorldSEnder
approved these changes
Jun 16, 2023
There was a problem hiding this comment.
Looks good to me.
Initially, I found confusing info about the feature unification of dependencies of proc-macros, but it seems to me now that features of dependencies of proc macros and features of normal dependencies are not unified, So the proc macro, targeting not(target_arch = "wasm32"), should correctly activate __proc_macro_workaround, while the rest of rest of the crate depends on stylist-core without that feature as usual.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #120
Fix #121
This pull request implements mitigates rust-lang/rust#111888 by implementing a temporary feature gate on
stylist-coreto disableJsValue.