make time_condition_edit.php use time_format var for select options #6872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the existing default Varriable time_format to adjust the options of the selects of "hours of day" and "time of day" accordingly
|
You are right I had not noticed this and agree that it should use the time_format variable. So I'm accepting your pull request. Thanks for sharing it. |
goldenpr
pushed a commit
to goldenpr/fusionpbx
that referenced
this pull request
Sep 9, 2024
Use the existing default Varriable time_format to adjust the options of the selects of "hours of day" and "time of day" accordingly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the existing default Variable time_format to adjust the options of the selects of "hours of day" and "time of day" accordingly.
We have been operating FusionPBX for our customers in Germany for several years. Over time, we have noticed many small things that the main user base probably does not notice. The AM and PM times are very unusual in Germany. Therefore I hope that this change will be accepted. There is already a default variable that lets you choose the time format. In my opinion, a user who selects 24 hours and activates the variable should no longer find AM PM times on the interface. If you notice this elsewhere, I would also try to fix it.