Addition of the ability to produce mutilayer firstwalls #303
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Aims to solve #302 . Adding the ability to create multilayer first walls. I've initially only created this for the submersion reactor, but the code is easily ported to the other reactor types if this is something seen as useful.
For the user the reactor will work identical to before is the firstwall_radial_thickness parameter is set as a float. If a list of floats, the first wall will be composed of layers with each item as a thickness:
firstwall_radial_thickness = [10,5,20]
I think the only reactor type that may require additional work for including is the segmented blanket reactor as the first wall wraps the sides of the blanket. It is likely you would not want multiple layers wrapping the blanket, but potentially just the last layer.
Types of changes
What types of changes does your code introduce to the Paramak?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.