Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of the ability to produce mutilayer firstwalls #303

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Allentro
Copy link

@Allentro Allentro commented Jan 28, 2023

Proposed changes

Aims to solve #302 . Adding the ability to create multilayer first walls. I've initially only created this for the submersion reactor, but the code is easily ported to the other reactor types if this is something seen as useful.

For the user the reactor will work identical to before is the firstwall_radial_thickness parameter is set as a float. If a list of floats, the first wall will be composed of layers with each item as a thickness:

firstwall_radial_thickness = [10,5,20]

I think the only reactor type that may require additional work for including is the segmented blanket reactor as the first wall wraps the sides of the blanket. It is likely you would not want multiple layers wrapping the blanket, but potentially just the last layer.

Types of changes

What types of changes does your code introduce to the Paramak?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • [ x] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@shimwell
Copy link
Member

Shall we go for a typing.iterable instead as this can be a tuple or a list. I know this means we no longer accept a float but it will help keep the code simple :-)

@shimwell
Copy link
Member

Could we cut the center column with a union (envelop) of all the first wall layers

@shimwell
Copy link
Member

it might be worth first syncing the fork then rebasing or merging develop into this feature branch as the CI tests are working again on develop branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants