added new census distribution over buildings UDF #97
Conversation
|
|
||
|
|
There was a problem hiding this comment.
Please run black to autoformat.
|
|
||
| #shorten the column name | ||
| gdf.columns = gdf.columns.map(lambda x:(str(x.split('|')[0])+str(x.split('|')[-1])) if '|' in x else x) | ||
| print(gdf.columns) |
There was a problem hiding this comment.
No need for print statement in helper function.
| suffix='centroid' | ||
| print(suffix) | ||
|
|
||
| #read the variables |
There was a problem hiding this comment.
| #read the variables | |
| # Read the variables |
Please standardize all comments to use sentence case and have a space between the # and first letter, and add this to the contributing md.
| return List[0][0] | ||
|
|
||
|
|
||
| import geopandas as gpd |
There was a problem hiding this comment.
Please run isort on every new .py file. This import statement should be at top of file.
|
|
||
| @fused.cache | ||
| def acs_5yr_meta(short=True): | ||
| import pandas as pd |
There was a problem hiding this comment.
Import statement at top of file. If it were a "rare" import statement that introduced latency at import, it'd make sense to have it within the function. In this case, pandas is common enough so it belongs at the top of the file.
| @@ -0,0 +1,35 @@ | |||
| import geopandas as gpd | |||
There was a problem hiding this comment.
In UDFs, import statement should go inside the UDF. You already have this import in line 11.
|
A naiive run of the UDF gives the following error at some zoom levels. What error-handling can be done to print a statement that is helpful to the user? When this error shows up, it's not clear for the user why it happens nor how to resolve it. 
|
|
|
||
| @fused.cache | ||
| def get_census(bbox, census_variable='Total Pop', scale_factor=200, is_density=True, year=2022): | ||
| from utils import acs_5yr_bbox |
There was a problem hiding this comment.
This import statement is incorrect. This function is already in the utils file so acs_5yr_bbox is already in scope and needn't be imported.
Added New population Distribution UDF