Skip to content

Commit

Permalink
fix warning in example
Browse files Browse the repository at this point in the history
  • Loading branch information
cbaggers committed Jul 27, 2017
1 parent ae8a10e commit f8a8229
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 6 deletions.
2 changes: 1 addition & 1 deletion Examples/Basics/SeekBar.js
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ progress.addSubscriber(function(x) {
sliderValue.value = (x.value / duration.value);
});

sliderValue.onValueChanged(function(val) {
sliderValue.onValueChanged(module, function(val) {
if (isInteracting)
progress.value = (val * duration.value);;
});
Expand Down
15 changes: 10 additions & 5 deletions todo
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,8 @@ src/iOS/LockScreenControls.uno:116: // {TODO} lower version support

- Seems to be possible in some cases to use backward to get to entries from previous playlists..which is itself is fine, but it seemed intermitant and (on android) I jumped back to the first playlist rather that the intermediate tracks. When do tracks get added to the history?

- fix the artwork downloading nonsence on android

- iOS: when playlist is done we keep getting 'Note' in the logs. Seems like somehting is still running. Stops when you press 'Stop', cool so it'll be something simple then.

- example: onvaluechanged needs a module or something

- optional duration? (can't work with streaming ofc)

## Done
Expand Down Expand Up @@ -74,4 +70,13 @@ I: not setting artwork causes crash
R: -

I: make more fields optional
R: -
R: -

I: Add support for local artwork files
R: -

I: example has 'onvaluechanged needs a module' warning
R: -

I: android artwork caching
R: dirt simple but will do the job for now.

0 comments on commit f8a8229

Please sign in to comment.