Introduce GitHub actions

.github/workflows/reviewdog.yml

@@ -1,27 +1,24 @@
-# This is a basic workflow to help you get started with Actions
+name: reviewdog
 
-name: CI
+on: pull_request
 
-# Controls when the action will run. Triggers the workflow on push or pull request
-# events but only for the master branch
-on:
-  push:
-    branches: [ master ]
-  pull_request:
-    branches: [ master ]
-
-# A workflow run is made up of one or more jobs that can run sequentially or in parallel
 jobs:
-  # This workflow contains a single job called "build"
-  build:
-    # The type of runner that the job will run on
+  actionlint:
+    name: golangci-lint
     runs-on: ubuntu-latest
-
-    # Steps represent a sequence of tasks that will be executed as part of the job
     steps:
-    # Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
-    - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
+      - uses: reviewdog/action-actionlint@v1
+        with:
+          reporter: github-pr-review
+          level: warning
 
-    # Runs a single command using the runners shell
-    - name: Run golangci-lint with reviewdog
-      uses: reviewdog/[email protected]
+  golangci-lint:
+    name: golangci-lint
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
+      - uses: reviewdog/action-golangci-lint@v2
+        with:
+          reporter: github-pr-review
+          level: warning

.github/workflows/test.yaml

@@ -0,0 +1,42 @@
+name: test
+
+on:
+  push:
+    branches: main
+  pull_request:
+
+jobs:
+  test:
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        mysql: ["5.6", "5.7", "8.0"]
+    services:
+      db:
+        image: mysql:${{ matrix.mysql }}
+        ports:
+          - 3306:3306
+        env:
+          MYSQL_ROOT_PASSWORD: root
+          MYSQL_DATABASE: sakila
+          MYSQL_USER: user
+          MYSQL_PASSWORD: password
+        options: >-
+          --health-cmd "mysqladmin ping"
+          --health-interval 10s
+          --health-timeout 5s
+          --health-retries 5
+    steps:
+      - uses: actions/checkout@v3
+      - name: setup go 1.19
+        uses: actions/setup-go@v3
+        with:
+          go-version: "1.19"
+          cache: true
+      - name: prepare test
+        run: mysql -uroot -proot -h127.0.0.1 -P3306 sakila < ./testdata/schema/sakila.sql
+      - name: test with MySQL ${{ matrix.mysql }}
+        run: go test -v -race ./...
+        env:
+          TEST_DSN: "root:root@tcp(127.0.0.1:3306)/sakila?parseTime=true"

docker-compose.yml

@@ -1,33 +1,36 @@
 version: '3'
 services:
   mysql5.6:
-    image: ${MYSQL_IMAGE:-mysql:5.6}
+    image: mysql:5.6
+    platform: linux/amd64
     ports:
-      - ${MYSQL_HOST:-127.0.0.1}:${MYSQL_PORT:-3306}:3306
+      - 3306:3306
     environment:
-      - MYSQL_ALLOW_EMPTY_PASSWORD=yes
+      - MYSQL_ROOT_PASSWORD=root
     # MariaDB >= 10.0.12 doesn't enable Performance Schema by default so we need to do it manually
     # https://mariadb.com/kb/en/mariadb/performance-schema-overview/#activating-the-performance-schema
     command: --performance-schema --secure-file-priv=""
     volumes:
       - ./testdata/schema/:/docker-entrypoint-initdb.d/:rw
   mysql5.7:
-    image: ${MYSQL_IMAGE:-mysql:5.7}
+    image: mysql:5.7
+    platform: linux/amd64
     ports:
-      - ${MYSQL_HOST:-127.0.0.1}:${MYSQL_PORT:-3307}:3306
+      - 3307:3306
     environment:
-      - MYSQL_ALLOW_EMPTY_PASSWORD=yes
+      - MYSQL_ROOT_PASSWORD=root
     # MariaDB >= 10.0.12 doesn't enable Performance Schema by default so we need to do it manually
     # https://mariadb.com/kb/en/mariadb/performance-schema-overview/#activating-the-performance-schema
     command: --performance-schema --secure-file-priv=""
     volumes:
       - ./testdata/schema/:/docker-entrypoint-initdb.d/:rw
   mysql8.0:
-    image: ${MYSQL_IMAGE:-mysql:8.0.3}
+    image: mysql:8.0
+    platform: linux/amd64
     ports:
-      - ${MYSQL_HOST:-127.0.0.1}:${MYSQL_PORT:-3308}:3306
+      - 3308:3306
     environment:
-      - MYSQL_ALLOW_EMPTY_PASSWORD=yes
+      - MYSQL_ROOT_PASSWORD=root
     # MariaDB >= 10.0.12 doesn't enable Performance Schema by default so we need to do it manually
     # https://mariadb.com/kb/en/mariadb/performance-schema-overview/#activating-the-performance-schema
     command: --performance-schema --secure-file-priv=""

runtests.sh

@@ -16,7 +16,7 @@ for PORT in 3306 3307 3308; do
     echo "### MySQL at port ${PORT}"
     echo "##########################"
     wait_mysql $PORT
-    export TEST_DSN="root:@tcp(127.1:${PORT})/sakila?parseTime=true"
+    export TEST_DSN="root:root@tcp(127.1:${PORT})/sakila?parseTime=true"
     go test -v ./...
 done
 

tableparser/tableparser_test.go

@@ -36,7 +36,7 @@ func TestParse(t *testing.T) {
 	}
 	tu.LoadJson(t, sampleFile, &want)
 
-	tu.Equals(t, table, want)
+	tu.Equals(t, want, table)
 }
 
 func TestGetIndexes(t *testing.T) {
@@ -49,7 +49,7 @@ func TestGetIndexes(t *testing.T) {
 		tu.WriteJson(t, "indexes.json", idx)
 	}
 	tu.Ok(t, err)
-	tu.Equals(t, idx, want)
+	tu.Equals(t, want, idx)
 }
 
 func TestGetTriggers(t *testing.T) {
@@ -77,5 +77,5 @@ func TestGetTriggers(t *testing.T) {
 		tu.WriteJson(t, sampleFile, triggers)
 	}
 	tu.Ok(t, err)
-	tu.Equals(t, triggers, want)
+	tu.Equals(t, want, triggers)
 }

tableparser/testdata/table003.json

@@ -42,7 +42,7 @@
         "String": "",
         "Valid": false
       },
-      "ColumnType": "smallint(5) unsigned",
+      "ColumnType": "smallint unsigned",
       "ColumnKey": "PRI",
       "Extra": "auto_increment",
       "Privileges": "select,insert,update,references",
@@ -88,11 +88,11 @@
         "Valid": false
       },
       "CharacterSetName": {
-        "String": "utf8",
+        "String": "utf8mb3",
         "Valid": true
       },
       "CollationName": {
-        "String": "utf8_general_ci",
+        "String": "utf8mb3_general_ci",
         "Valid": true
       },
       "ColumnType": "varchar(255)",
@@ -141,11 +141,11 @@
         "Valid": false
       },
       "CharacterSetName": {
-        "String": "utf8",
+        "String": "utf8mb3",
         "Valid": true
       },
       "CollationName": {
-        "String": "utf8_general_ci",
+        "String": "utf8mb3_general_ci",
         "Valid": true
       },
       "ColumnType": "text",
@@ -201,7 +201,7 @@
         "String": "",
         "Valid": false
       },
-      "ColumnType": "year(4)",
+      "ColumnType": "year",
       "ColumnKey": "",
       "Extra": "",
       "Privileges": "select,insert,update,references",
@@ -254,7 +254,7 @@
         "String": "",
         "Valid": false
       },
-      "ColumnType": "tinyint(3) unsigned",
+      "ColumnType": "tinyint unsigned",
       "ColumnKey": "MUL",
       "Extra": "",
       "Privileges": "select,insert,update,references",
@@ -313,7 +313,7 @@
         "String": "",
         "Valid": false
       },
-      "ColumnType": "tinyint(3) unsigned",
+      "ColumnType": "tinyint unsigned",
       "ColumnKey": "MUL",
       "Extra": "",
       "Privileges": "select,insert,update,references",
@@ -372,7 +372,7 @@
         "String": "",
         "Valid": false
       },
-      "ColumnType": "tinyint(3) unsigned",
+      "ColumnType": "tinyint unsigned",
       "ColumnKey": "",
       "Extra": "",
       "Privileges": "select,insert,update,references",
@@ -478,7 +478,7 @@
         "String": "",
         "Valid": false
       },
-      "ColumnType": "smallint(5) unsigned",
+      "ColumnType": "smallint unsigned",
       "ColumnKey": "",
       "Extra": "",
       "Privileges": "select,insert,update,references",
@@ -577,11 +577,11 @@
         "Valid": false
       },
       "CharacterSetName": {
-        "String": "utf8",
+        "String": "utf8mb3",
         "Valid": true
       },
       "CollationName": {
-        "String": "utf8_general_ci",
+        "String": "utf8mb3_general_ci",
         "Valid": true
       },
       "ColumnType": "enum('G','PG','PG-13','R','NC-17')",
@@ -636,11 +636,11 @@
         "Valid": false
       },
       "CharacterSetName": {
-        "String": "utf8",
+        "String": "utf8mb3",
         "Valid": true
       },
       "CollationName": {
-        "String": "utf8_general_ci",
+        "String": "utf8mb3_general_ci",
         "Valid": true
       },
       "ColumnType": "set('Trailers','Commentaries','Deleted Scenes','Behind the Scenes')",
@@ -703,7 +703,7 @@
       },
       "ColumnType": "timestamp",
       "ColumnKey": "",
-      "Extra": "on update CURRENT_TIMESTAMP",
+      "Extra": "DEFAULT_GENERATED on update CURRENT_TIMESTAMP",
       "Privileges": "select,insert,update,references",
       "ColumnComment": "",
       "GenerationExpression": "",
@@ -766,4 +766,4 @@
     }
   ],
   "Triggers": []
-}
+}