docs(#3): document multi-project Vertex provider usage - #4
Conversation
Adds a new "Using alongside other Vertex providers" section to README.md covering the multi-project, multi-provider use case that works today but was previously undocumented. Content includes: - Environment variable independence table for xai-vertex, anthropic-vertex, and google-vertex - Worked example showing two projects serving three providers - Warning that XAI_VERTEX_PROJECT_ID must be set explicitly to avoid silent misrouting via the fallback chain - Fully-qualified model spec requirement (already covered elsewhere, generalized here) - google-vertex's dual project+location requirement and failure mode - Ground truth methods for verifying which model answered (PI_* env vars, session JSONL, responseId, cost arithmetic) References existing Install and Requirements sections per triage guidance rather than duplicating the project fallback chain or ADC setup. Closes #3
|
🤖 Finished Review · ✅ Success · Started 7:43 PM UTC · Completed 7:52 PM UTC Commit: Runtime: pi · Model: xai-vertex/xai/grok-4.6 → xai/grok-4.6 · Effort: high · Cost: $2.33 |
|
Risk Assessment: low (1/5) DetailsDocs-only README addition (1 file, 89 lines), no protected or security-sensitive paths, bot author, and linked issue #3 matches the change with the proposed sections present. Previous runRisk Assessment: low (1/5) DetailsDocs-only README addition (1 file, 75 lines), no protected or security-sensitive paths, bot author, and linked issue #3 matches the change with all proposed sections present. |
ReviewFindingsLow
Previous runReviewFindingsLow
Labels: PR adds user-facing README documentation for multi-project Vertex provider usage. |
|
/fs-fix Review of the new "Using alongside other Vertex providers" section against the shipped extensions and today's verified runs. Please apply these four changes to README.md only; keep every commit signed off (DCO is enforced here).
Everything else in the section checks out: the three-segment spec advice, the |
|
🤖 Finished Fix · ✅ Success · Started 8:07 PM UTC · Completed 8:16 PM UTC Commit: Runtime: claude · Model: sonnet → claude-sonnet-4-5@20250929 · Effort: high · Cost: $1.44 |
Address four review findings on the "Using alongside other Vertex providers" section: 1. Fix anthropic-vertex resolution order in environment variables table - Updated project variable column to exact resolution order from vendored v0.1.13 - Updated location column with full fallback chain and default - Rewrote intro sentence to reflect that only xai-vertex puts its own variable first - Added consequence statement about Claude/Gemini project split limitation 2. Fix worked example location variables - Changed us-central1 to global for both GOOGLE_CLOUD_LOCATION and CLOUD_ML_REGION - Added parenthetical explaining xai-vertex ignores location variables 3. Remove ambiguous v0.2.0 printing claim from google-vertex subsection - Deleted sentence that incorrectly suggested xai-vertex prints diagnostic messages 4. Add "In fullsend" subsection - Document per-agent model selection via config.yaml and fullsend CLI - Explain XAI_VERTEX_PROJECT_ID precedence in fullsend context - Link to pi runtime docs for full precedence Addresses review feedback on #4
🔧 Fix agent — iteration 1 (bot-triggered)Successfully addressed all four review findings on PR #4. Fixed anthropic-vertex environment variable resolution order documentation, corrected worked example location variables from us-central1 to global, removed ambiguous printing claim, and added fullsend-specific subsection documenting per-agent configuration. Fixed (4):
Tests: passedNext steps:
|
|
/fs-fix One wording fix in README.md, under "### Always use fully qualified model specs": the closing line says "Use the three-segment form in scripts: |
|
🤖 Review · Commit: |
|
🤖 Finished Fix · ✅ Success · Started 8:19 PM UTC · Completed 8:24 PM UTC Commit: Runtime: claude · Model: sonnet → claude-sonnet-4-5@20250929 · Effort: high · Cost: $0.85 |
The closing line under "Always use fully qualified model specs" said "Use the three-segment form in scripts" but only the Grok spec (xai-vertex/xai/grok-4.6) is three segments; the Gemini spec (google-vertex/gemini-3.7-flash) is provider/model (two segments). Changed to: "Use the fully qualified provider/model form in scripts: xai-vertex/xai/grok-4.6 (three segments, because this provider's model id carries the xai/ publisher prefix) and google-vertex/gemini-3.7-flash." Addresses human instruction on PR #4. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
🔧 Fix agent — iteration 2 (human-triggered)Addressed the wording fix in README.md under the 'Always use fully qualified model specs' section. Changed the documentation to clarify that only xai-vertex/xai/grok-4.6 is three segments (because the model id contains the xai/ publisher prefix), while google-vertex/gemini-3.7-flash is the standard two-segment provider/model form. All tests passed. Fixed (1):
Tests: passed Decision points
Next steps:
|
|
🤖 Finished Review · ✅ Success · Started 8:27 PM UTC · Completed 8:34 PM UTC Commit: Runtime: pi · Model: xai-vertex/xai/grok-4.6 → xai/grok-4.6 · Effort: high · Cost: $1.49 |
|
🤖 Finished Retro · ✅ Success · Started 8:46 PM UTC · Completed 9:01 PM UTC Commit: Runtime: claude · Model: sonnet → claude-sonnet-4-5@20250929 · Effort: high · Cost: $2.93 |
Retrospective Analysis: PR #4 (Issue #3)Timeline: Triage failed → Triage succeeded → Code → Review → Human feedback → Fix → Fix → Review → Merged What Went Well
Human-Agent Review DeltaThe human reviewer (waynesun09) identified 4 substantive issues that the review agent missed:
The review agent only caught text-level clarity issues. It did not verify documentation claims against source code, service availability, or production configurations. Evidence Supporting Existing Issues
Workflow QualityReview quality: Medium. Agent caught surface-level issues but missed substantive technical errors requiring source verification. Rework rate: 2 fix iterations after initial review. Acceptable for docs PR with nuanced technical claims. Token cost: Review run 1: $2.33, Fix run 1: $1.44, Fix run 2: $0.85, Review run 3: $1.49. Total ~$6.11 for agent work. Reasonable for documentation PR requiring multiple verification rounds. Time to resolution: From ready-to-code label to merge: ~4 hours. Within normal range for docs PR with human oversight. No New ProposalsAll improvement opportunities identified in this retro are already covered by existing open issues in fullsend-ai/agents (see evidence notes above). No new proposals warranted. |
Summary
Adds a "Using alongside other Vertex providers" section to README.md documenting how to run this provider alongside other Vertex AI providers (Claude, Gemini) across different GCP projects. This setup works today but was previously undocumented.
What's included
XAI_VERTEX_PROJECT_IDexplicitly when using different projects, since this provider falls back through other providers' variables and will silently misroute traffic otherwisexai/grok-4.6hits built-in xai provider,gemini-3.7-flashexists under both google and google-vertex)GOOGLE_CLOUD_PROJECTandGOOGLE_CLOUD_LOCATIONare requiredTesting
npm run cipasses (lint + tests)Closes #3
Post-script verification
agent/3-multi-project-docs)2bfe35243b1aab845273ff0d183956948b263cfd..HEAD)