Skip to content

docs(skills): add spec-start-github for issue-driven spec PRs - #821

Merged
ifireball merged 2 commits into
fullsend-ai:mainfrom
ifireball:cursor/spec-start-github-skill
May 17, 2026
Merged

docs(skills): add spec-start-github for issue-driven spec PRs#821
ifireball merged 2 commits into
fullsend-ai:mainfrom
ifireball:cursor/spec-start-github-skill

Conversation

@ifireball

Copy link
Copy Markdown
Member

Summary

  • Add skills/spec-start-github/SKILL.md: thin GitHub layer (issue fetch, canonical prompt, agent/<issue>-spec-* branch rules, commit + local gh pr create vs harness handoff) that defers the headless spec procedure to spec-start (no duplicated checklist/templates).
  • Update skills/spec-start/SKILL.md with cross-links so the two skills are paired for issue-driven runs.

Context

Implements fullsend-ai/fullsend#803 (sub-issue of planning-oriented agents / spec workflows).

Verification

  • make lint (staged skill files) passed locally.

Made with Cursor

Add a thin skill that binds spec-start to GitHub (issue as canonical
prompt, agent/<issue>-spec-* branches, local gh pr create vs harness
post-script). Cross-link from spec-start for pairing.

Closes fullsend-ai#803

Co-authored-by: Cursor <cursoragent@cursor.com>
@github-actions

Copy link
Copy Markdown

fullsend review is working on this — view logs

@github-actions

github-actions Bot commented May 12, 2026

Copy link
Copy Markdown

Site preview

Preview: https://6982a52a-site.fullsend-ai.workers.dev

Commit: 7bd3fb23f83e6fec6bb75002f132c70653dfe508

@ifireball ifireball self-assigned this May 12, 2026
@fullsend-ai-review

fullsend-ai-review Bot commented May 12, 2026

Copy link
Copy Markdown

Review

Findings

Medium

  • [correctness] skills/spec-start-github/SKILL.md, skills/spec-start/SKILL.md — Skills in this repo are maintained as identical copies across three directories (skills/, .claude/skills/, .cursor/skills/). This PR adds skills/spec-start-github/SKILL.md and modifies skills/spec-start/SKILL.md (cross-reference) only in skills/, without syncing to .claude/skills/ or .cursor/skills/. After merge, the new skill will not be available in Claude Code or Cursor contexts, and the existing spec-start skill will show stale content (missing cross-link) in those contexts.
    Remediation: Copy skills/spec-start-github/ to .claude/skills/spec-start-github/ and .cursor/skills/spec-start-github/. Copy the updated skills/spec-start/SKILL.md to .claude/skills/spec-start/SKILL.md and .cursor/skills/spec-start/SKILL.md.

Low

  • [intent-alignment] internal/dispatch/gcf/provisioner_test.go — This test refactor (extracting a fake PEM literal to a variable) is unrelated to the spec-start-github skill work described in the PR title and linked issue Skill: spec-start-github — issue-driven spec run, artifacts on a PR #803. The change itself is correct and clean, but represents unrelated scope in a docs-only PR.
Previous run

Review: #821

Head SHA: f441e1b
Timestamp: 2026-05-12T00:00:00Z
Outcome: approve

Summary

Clean documentation-only PR that adds the spec-start-github skill as a thin GitHub layer (issue fetch, branch conventions, commit and PR mechanics) on top of the existing spec-start skill, with proper bidirectional cross-links. The change matches the scope of issue #803, follows existing skill patterns (frontmatter, structure, naming), and includes good safety measures (branch collision detection, scan-secrets guidance, harness vs local mode separation). No findings across any review dimension.

Findings

No findings.

Footer

Outcome: approve
This review applies to SHA f441e1b437a9b1c4f8c10640040aa0ccd10e31db. Any push to the PR head clears this review and requires a new evaluation.

@ralphbean ralphbean left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Two non-blocking notes inline.

Comment thread skills/spec-start/SKILL.md
Comment thread skills/spec-start-github/SKILL.md
Resolve spec-start description conflict: keep main's qna.md format note and
the PR's spec-start-github pairing. Lead spec-start-github description with
"Use when..." per review. Use truncated test PEM stub to satisfy gitleaks.

Co-authored-by: Cursor <cursoragent@cursor.com>
@ifireball

Copy link
Copy Markdown
Member Author

Babysit update: merged `main` (resolved `spec-start` description conflict — kept the `qna.md` format sentence and the `spec-start-github` pairing). Updated `spec-start-github` frontmatter to lead with Use when... per review. CI is green and the branch is mergeable.

@fullsend-ai-review fullsend-ai-review Bot added the requires-manual-review Review requires human judgment label May 17, 2026
@ifireball
ifireball added this pull request to the merge queue May 17, 2026
Merged via the queue into fullsend-ai:main with commit 9e89539 May 17, 2026
6 checks passed
@ifireball
ifireball deleted the cursor/spec-start-github-skill branch May 17, 2026 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

requires-manual-review Review requires human judgment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants