fix(#731): remove stale blocked label on sufficient triage results

[fullsend-ai-coder]

The sufficient case in post-triage.sh applied ready-to-code or triaged labels but never removed a stale blocked label. The other outcome handlers (insufficient, duplicate, feature-request) already called remove_label "blocked", but sufficient was missing it. This meant a re-triaged issue could end up with both blocked and ready-to-code labels simultaneously.

Add remove_label "blocked" to the sufficient handler, matching the pattern used by the other action handlers. The existing sufficient-removes-blocked-label test now passes.

---

Closes #731

Post-script verification

• Branch is not main/master (agent/731-sufficient-remove-blocked)
• Secret scan passed (gitleaks — bc3164f938e8035848593228703b145e0a74e43b..HEAD)
• Pre-commit hooks passed (authoritative run on runner)
• Tests ran inside sandbox

[github-actions]

fullsend review is working on this — view logs

[github-actions]

Site preview

Preview: https://0b2b9182-site.fullsend-ai.workers.dev

Commit: e29de64136dd7ad380c51cc80300cd77fc273f1a

[fullsend-ai-review]

Review: #743

Head SHA: e29de64
Timestamp: 2026-05-08T00:00:00Z
Outcome: approve

Summary

This is a clean, well-scoped bug fix that adds the missing remove_label "blocked" and remove_label "needs-info" calls to the sufficient handler in post-triage.sh. The change follows the exact pattern already established by the other action handlers (insufficient, duplicate, blocked, feature-request), which all clean up stale labels before applying their next-state label. The needs-info removal is a minor scope expansion beyond issue #731's explicit acceptance criteria, but it is the correct behavior — the blocked handler already removes both ready-to-code and needs-info, so sufficient should symmetrically remove both blocked and needs-info. The new test covers the added behavior and follows the existing test patterns. No security, injection, or style concerns.

Findings

No critical, high, medium, low, or info findings.

Footer

Outcome: approve
This review applies to SHA e29de64136dd7ad380c51cc80300cd77fc273f1a. Any push to the PR head clears this review and requires a new evaluation.

Previous run

Review: #743

Head SHA: 54e5a88
Timestamp: 2026-05-08T12:00:00Z
Outcome: approve

Summary

Clean, minimal fix that adds the missing remove_label "blocked" call to the sufficient case in post-triage.sh, matching the pattern already used by all other action handlers (insufficient, duplicate, feature-request). The change is correctly scoped to issue #731, placement within the handler is appropriate (after posting the comment, before applying the next-state label), and an existing test (sufficient-removes-blocked-label) already asserts this behavior. No security, injection, or style concerns.

Findings

Info

• [Correctness] internal/scaffold/fullsend-repo/scripts/post-triage.sh:148 — The sufficient handler also does not remove the needs-info label, which could become stale if an issue transitions from insufficient to sufficient. This is the same class of bug that this PR fixes for blocked, but for a different label. Consider tracking separately.

Footer

Outcome: approve
This review applies to SHA 54e5a88a41de1b0218434d73119973f48d2ea57c. Any push to the PR head clears this review and requires a new evaluation.

[rh-hemartin]

/fix

[github-actions]

fullsend fix is working on this — view logs

[rh-hemartin]

/fix

[github-actions]

fullsend fix is working on this — view logs

[fullsend-ai-coder]

🔧 Fix agent — iteration 1 (human-triggered)

Addressed 1 info-level review finding: added remove_label "needs-info" to the sufficient handler to prevent stale labels when issues transition from insufficient to sufficient. Added corresponding test case.

Fixed (1):

1. sufficient handler does not remove needs-info label (internal/scaffold/fullsend-repo/scripts/post-triage.sh): Added remove_label "needs-info" to the sufficient handler alongside the existing remove_label "blocked", preventing stale needs-info labels when an issue transitions from insufficient to sufficient. Also added a corresponding test case.

Tests: passed

Decision points

• Placed remove_label needs-info next to remove_label blocked in the existing stale-labels removal block (alternatives: Separate removal block, Combined into a loop; rationale: Matches the existing pattern used by the blocked handler which also removes multiple labels individually)

_{Updated by fullsend fix agent}

[github-actions]

fullsend review is working on this — view logs