docs(#6781): promote forge-abstraction to explicit AGENTS.md bullet - #6783
Conversation
Add a top-level bullet point in the "How to work in this repo" section for the forge-abstraction rule, placed after the Go coverage gate and before the secrets bullet. The rule was previously discoverable only via the topic-guidance table, which required agents to recognize that setting repository variables is a forge operation — a connection the code agent on PR #6779 failed to make. Promoting it to an inline bullet mirrors the pattern used for other critical rules (DCO, coverage gate, CLI docs) and makes the architectural invariant harder to miss for both code and review agents. Closes #6781
|
🤖 Finished Review · ✅ Success · Started 6:30 PM UTC · Completed 6:41 PM UTC Commit: Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $2.85 |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Risk Assessment: low (1/5) DetailsDocs-only 1-line addition to AGENTS.md by a bot author with no security-sensitive files, no CI changes, and no dependency changes. The change is trivially small and easily revertible. |
ReviewFindingsMedium
|
|
🤖 Finished Retro · ✅ Success · Started 10:08 AM UTC · Completed 10:16 AM UTC Commit: Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $1.71 |
Retro: PR #6783 — promote forge-abstraction to explicit AGENTS.md bulletTimelineThis PR is the product of a clean retro-to-fix pipeline originating from PR #6779, where the code agent violated the forge-abstraction rule by shelling out to
Total automation cost: $5.09 · Rework iterations: 0 · Time to merge: 5 days (human review latency on governance file) AssessmentThis workflow executed cleanly. The retro-to-fix pipeline worked exactly as designed: the retro agent identified a real root cause, the triage agent correctly categorized it, the code agent produced correct code on the first try (proper placement after the Go coverage gate bullet, matching the existing bullet pattern), and the review agent found the one appropriate finding (AGENTS.md is a protected governance file requiring human approval). Zero rework, no fix agent needed. The 5-day human review latency is expected behavior — the Evidence for existing issues (no new proposals needed)
|
Summary
Adds a top-level bullet point for the forge-abstraction rule in the "How to work in this repo" section of
AGENTS.md. The rule was previously listed only in the topic-guidance table, which required agents to infer that operations like setting repository variables are forge operations. This promotion mirrors the pattern used for other critical rules (DCO, coverage gate, CLI docs) and makes the architectural invariant — all forge operations must go throughforge.Client— harder to miss.Changes
docs/contributing/forge-abstraction.mdfor full detailsTesting
lycheelink checker passes onAGENTS.mdforge.Clientandforge-abstraction.mdare present inAGENTS.mdgitlintpasses on commit messageChecklist
!for breaking changes)Closes #6781
Post-script verification
agent/6781-promote-forge-abstraction-bullet)e90aca92240c9d478677c6c5cc70e0a9b0edb95a..HEAD)