feat: list fullsend slash commands in onboarding PR body

[shairevivo]

What

Adds a Getting started section to the onboarding (enroll) PR body created by the onboard bot on fullsend/onboard branches, listing the primary /fs-* slash commands with one-line descriptions.

Why

The onboarding PR is a user's first touchpoint with fullsend, but its body never mentioned the available commands. On mintmaker-renovate-image#456 a user typed /agentic_review (a Qodo command) instead of /fs-review — a discoverability problem. Introducing the commands right in the onboarding PR body addresses this.

Change

internal/scaffold/fullsend-repo/scripts/reconcile-repos.sh — extend ENROLL_PR_BODY with:

• /fs-triage — triage an issue (categorize, label, and assess it)
• /fs-code — ask the agent to implement a fix for an issue and open a PR
• /fs-review — request an agent review of a pull request
• /fs-fix — have the agent address review feedback on a pull request
• /fs-retro — run a retrospective to capture improvement ideas
• /fs-prioritize — have the agent prioritize an issue

Command names and their issue-vs-PR semantics were taken from the authoritative dispatcher (dispatch.yml issue_comment routing).

Verification

• bash -n + shellcheck (pre-commit) pass; sourced the variable to confirm backticks render as inline code.
• go test ./internal/scaffold/ passes.

Closes #2165

🤖 Generated with Claude Code

[github-actions]

E2E tests did not run

E2E tests run automatically for org/repo members and collaborators on pull requests.

For other contributors, a maintainer must add the ok-to-test label after the latest push.

See E2E testing guide for details.

[github-actions]

E2E tests did not run

E2E tests run automatically for org/repo members and collaborators on pull requests.

For other contributors, a maintainer must add the ok-to-test label after the latest push.

See E2E testing guide for details.

[qodo-code-review]

PR Summary by Qodo

Document Fullsend slash commands in onboarding PRs

✨ Enhancement 📝 Documentation 🕐 Less than 10 minutes

AI Description

• Adds Getting started guidance to generated Fullsend onboarding pull requests.
• Lists six primary slash commands with issue and pull request purposes.
• Improves command discoverability at repositories' first Fullsend touchpoint.

Diagram

graph TD
  A["Repo config"] --> B["Reconcile script"] --> C["Onboarding PR"] --> D["Repository user"] --> E["Slash commands"] --> F["Agent dispatcher"]

Loading

High-Level Assessment

Embedding concise command guidance directly in the generated onboarding PR is the best fit because it addresses discoverability at the user's first Fullsend touchpoint without adding runtime dependencies. Linking external documentation or dynamically deriving dispatcher routes would add indirection or coupling for a small, stable command set.

Files changed (1) +12 / -1

Enhancement (1) +12 / -1

reconcile-repos.shAdd slash-command guidance to onboarding PR bodies +12/-1

Add slash-command guidance to onboarding PR bodies

• Extends the generated enrollment pull request body with a Getting started section. It documents six primary /fs-* commands and clarifies whether each applies to issues or pull requests.

internal/scaffold/fullsend-repo/scripts/reconcile-repos.sh

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

[qodo-code-review]

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📜 Skill insights (0)

1. Misstates command contexts ✓ Resolved 🐞 Bug ≡ Correctness

Description

The Getting started text says all listed commands can be commented on an issue or pull request, but
/fs-code and /fs-prioritize are issue-only while /fs-review and /fs-fix are
pull-request-only. Users following this guidance can issue commands in unsupported contexts where
the dispatcher will not run them.

Code

internal/scaffold/fullsend-repo/scripts/reconcile-repos.sh[45]

+Once this PR is merged, interact with fullsend by commenting one of these slash commands on an issue or pull request:

Relevance

●●● Strong

Team has accepted similar entity-context correctness fixes for dispatcher-related docs/logic (PR
#1688).

PR-#1688

ⓘ Recommendations generated based on similar findings in past PRs

Evidence

The changed sentence makes the blanket issue-or-PR claim, while the repository's dispatcher gates
the commands by entity type. The context ADR and command documentation independently confirm the
intended semantics.

internal/scaffold/fullsend-repo/scripts/reconcile-repos.sh[45-52]
.github/workflows/reusable-dispatch.yml[193-213]
.github/workflows/reusable-dispatch.yml[227-231]
docs/ADRs/0076-slash-command-entity-context-separation.md[63-75]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

### Issue description
The onboarding body incorrectly claims every listed slash command works on either an issue or pull request. The dispatcher enforces entity-specific contexts: `/fs-code` and `/fs-prioritize` are issue-only, while `/fs-review` and `/fs-fix` are pull-request-only.

### Issue Context
Update the generated Getting started text so users can identify the supported target for each command. Preserve the command descriptions and ensure the final Markdown remains valid in `ENROLL_PR_BODY`.

### Fix Focus Areas
- internal/scaffold/fullsend-repo/scripts/reconcile-repos.sh[45-52]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

---

Context sources

✅ Compliance rules (platform): 67 rules

✅ Skills: writing-user-docs, writing-adrs

Review mode: 🚀 Fast: This is a localized, low-risk shell-string change that only augments onboarding PR documentation and does not alter runtime command behavior.

Tip of the day

💡 Did you know, you can describe a rule in plain language on the Rules page and Qodo drafts it for you

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

[ralphbean]

/fs-review

[fullsend-ai-review]

🤖 Finished Review · ✅ Success · Started 2:40 PM UTC · Completed 2:52 PM UTC

Commit: 2b27d45 · View workflow run →

Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $2.53

[fullsend-ai-review]

Review

Findings

Low

• [Technical accuracy] internal/scaffold/fullsend-repo/scripts/reconcile-repos.sh:54 — /fs-prioritize is listed as (issue only) but ADR 0076 classifies it as allowed in "Either" context (issue or PR), and the dispatch workflow (dispatch.yml lines 161–164) has no ISSUE_HAS_PR guard restricting it to issues. The normative ADR and actual dispatch routing both permit PRs. Listing it as "issue only" could mislead users into thinking the command will not work on PRs. Note: docs/agents/prioritize.md also says "Issue comment", so the inconsistency extends beyond this PR — but the onboarding body should not propagate the error to new users.
  Remediation: Change - \/fs-prioritize` (issue only)to- `/fs-prioritize` (issue or PR)` to match ADR 0076 and the dispatch routing, or update ADR 0076 and the dispatch code if the intent truly is issue-only.

[waynesun09]

[HIGH] Fix does not cover the update-path PR where the reported incident actually happened

internal/scaffold/fullsend-repo/scripts/reconcile-repos.sh, UPDATE_PR_BODY (line 56) — not on a diff line this PR touches, so noting it here.

This PR only appends the new "Getting started" section to ENROLL_PR_BODY. UPDATE_PR_BODY (used for the "shim is stale, re-sync" path, title chore: update fullsend shim workflow, on the fullsend/onboard branch) is left untouched. The incident that motivated issue #2165 was exactly this update-path PR (title chore: update fullsend shim workflow, body matching UPDATE_PR_BODY verbatim) — the repo was already enrolled when the wrong slash command was typed. Since this diff doesn't touch UPDATE_PR_BODY, that same scenario will still recur, and #2165's own validation criteria ("the next 3 onboarding PRs ... should include slash command documentation") won't be met for update-path PRs.

Suggestion: factor the "Getting started" block into a shared variable and append it to UPDATE_PR_BODY as well, or explicitly scope this PR to "enrollment-only" and open a follow-up issue for the update path so the original incident is actually prevented from recurring.

[waynesun09]

Review sweep at head 378363f. One inline finding on the new drift guard, plus two findings below that land on lines this diff doesn't touch, so noting them here.

---

[MEDIUM] Already-open onboarding PRs never get the new body — the exact repo from #2165 stays uncovered

internal/scaffold/fullsend-repo/scripts/reconcile-repos.sh, line 459 (existing-PR branch) — not on a diff line this PR touches.

Verified at head, lines 443-476: --body is only ever passed to gh pr create. In the stale-shim/update branch, when EXISTING_PR is non-empty (line 458), the script pushes the refreshed shim to the branch, logs "Updated shim on existing PR for $REPO" at line 459, and never calls gh pr edit --body. The enrollment branch behaves identically at lines 466-476 (write_shim_to_branch_from_default only, no body reconciliation).

Reconciliation is therefore convergent for shim content but not for PR body: every repo that already has an open fullsend/onboard PR when this merges keeps its old, command-less body indefinitely. That is precisely the mintmaker-renovate-image#456 situation cited in issue #2165, and it means #2165's validation criteria ("the next 3 onboarding PRs should include slash command documentation") is met only for PRs created after this lands.

This is distinct from the already-resolved thread about UPDATE_PR_BODY lacking the section (fixed in e0e72b5) — that was about the body's content; this is about the body never being re-applied to an existing PR.

Suggestion: In both existing-PR branches, reconcile the body too — e.g. gh pr edit "$EXISTING_PR" --repo "$ORG/$REPO" --body "$UPDATE_PR_BODY" (and the ENROLL_PR_BODY equivalent), guarded so it only rewrites bodies the bot owns and only when the body actually differs, to avoid notification churn. At minimum, state the limitation in the PR description so #2165's validation criteria are assessed against newly created PRs only.

---

[MEDIUM] Per-repo installation onboarding PR still ships no slash-command catalog

internal/repos/scaffold_metadata.go, line 28 — file not touched by this PR.

The fix covers only the org-mode onboard bot. The per-repo installation path (fullsend repos install) builds its own first-touchpoint PR body from defaultScaffoldPRBody (line 28), still just "This PR adds the fullsend scaffold files for per-repo installation.\n\nMerge this PR to activate fullsend workflows." — freshInstallMetadata() consumes it unchanged. Meanwhile reconcile-repos.sh explicitly skips those repos (check_per_repo_guard "$REPO" "enrollment" at line 411, continue at 413), so per-repo installs get slash-command discovery from neither path.

Issue #2165 scoped the ask to the onboard bot's PR body, so this is a completeness gap rather than a scope violation — but the incident class ("user does not know which commands exist") is identical, and this PR's review history already accepted that finding shape: the resolved UPDATE_PR_BODY thread was exactly "the fix misses a population with the same incident class".

Suggestion: Either add the same Getting started block to the per-repo PR body — ideally sourced from one shared definition so the two catalogs cannot diverge — or state in the PR description that per-repo installs are deliberately out of scope and open a follow-up issue.

[rh-hemartin]

Links should point to the live docs.

[shairevivo]

Links should point to the live docs.

Done, fixed.

[waynesun09]

Review sweep at head 33faae6 (guard-hardening + docs-links commits). Two findings, both inline.