docs(#6163): add staging warning to go-code.md coverage procedure - #6164
Conversation
The "Verifying patch coverage locally" section in go-code.md step 1 was missing a warning that new files must be staged before running `git diff --name-only`. Without staging, new Go files are invisible to the command and the coverage check silently skips them. Add the same staging note that SKILL.md step 1 already includes, keeping the two coverage procedures consistent. Closes #6163
|
🤖 Finished Review · ✅ Success · Started 6:01 AM UTC · Completed 6:09 AM UTC Commit: |
Site previewPreview: https://a444f89c-site.fullsend-ai.workers.dev Commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Looks good to me Labels: PR modifies documentation under docs/contributing/ |
|
🤖 Finished Retro · ✅ Success · Started 8:49 AM UTC · Completed 9:01 AM UTC Commit: Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $4.77 |
Retro: PR #6164 — docs(#6163): add staging warning to go-code.md coverage procedureVerdict: Clean end-to-end autonomous workflow. No new proposals — all findings map to existing open issues. Timeline
Workflow quality
Evidence for existing issues (skipped as proposals)
What went wellThis is a success story for the retro → triage → code → review pipeline. The retro agent identified a real documentation inconsistency, the triage agent correctly scoped it, the code agent resolved it on the first attempt, and the review agent correctly approved. The full autonomous chain from issue detection to merge-ready PR completed in under 20 minutes with zero rework. |
Summary
Add a staging warning to the "Verifying patch coverage locally" procedure in
docs/contributing/go-code.mdstep 1, matching the equivalent warning already present inskills/check-patch-coverage/SKILL.mdstep 1. Without this note, an agent following go-code.md would not know togit addnew files before runninggit diff --name-only, causing the coverage check to silently skip unstaged new files.Changes
git add)" note to step 1 of the coverage procedure indocs/contributing/go-code.mdskills/check-patch-coverage/SKILL.mdTesting
docs/contributing/go-code.mdandskills/check-patch-coverage/SKILL.mdcontain equivalent staging warningsChecklist
!for breaking changes)Closes #6163
Post-script verification
agent/6163-add-staging-warning)3c7f5d034d3f9ace8efd3608a6322903da907809..HEAD)