docs(#6160): add ADR-0045 maintenance step to harness-composition checklist - #6161
docs(#6160): add ADR-0045 maintenance step to harness-composition checklist#6161fullsend-ai-coder[bot] wants to merge 1 commit into
Conversation
…cklist The harness-composition.md checklist covered merge function updates (steps 1-5) but did not include updating ADR-0045 when a field's forge-level classification changes. This caused a HIGH review finding on PR #6139, where the code agent followed all checklist steps but left ADR-0045's field classification tables contradicting the change. Add step 6 instructing developers to update the field classification tables, ForgeConfig struct definition, and merge-rules table in ADR-0045 when adding forge-overridable fields or moving fields between classification tiers. Note: pre-commit could not run (sandbox network policy blocks git fetch for hook environment setup). The post-script runs pre-commit authoritatively on the runner. Closes #6160
|
🤖 Finished Review · ✅ Success · Started 10:32 PM UTC · Completed 10:39 PM UTC Commit: |
Site previewPreview: https://6fcb1c34-site.fullsend-ai.workers.dev Commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Looks good to me Labels: PR updates the harness-composition contributing guide with an ADR maintenance checklist step. |
![fullsend-ai-review[bot]](https://avatars.githubusercontent.com/in/3478501?s=60&v=4){kind=small}
fullsend-ai-review
Bot
added
ready-for-merge
|
Instead of exhorting agents to update ADRs, we should move all of that detail out of the ADR and into somewhere else in docs/ and exhort the agent to update that and link to it from the ADR. The core ADR decision should be small-ish "do forge portable harnesses" but, the details about precedence rules and all that should be a living thing. |
|
🤖 Finished Retro · ❌ Failure · Started 8:22 PM UTC · Completed 8:22 PM UTC Commit: |
1 participant
Summary
Adds step 6 to the harness-composition.md checklist, instructing developers to update ADR-0045's field classification tables when adding forge-overridable fields or moving fields between classification tiers. This addresses a documentation gap that caused a HIGH review finding on PR #6139 — the code agent followed all existing checklist steps but left ADR-0045 contradicting its changes.
Related Issue
Closes #6160
Changes
docs/contributing/harness-composition.mdForgeConfigstruct definition, and merge-rules tableTesting
make lint— pre-commit hooks could not run in sandbox (network policy); post-script runs authoritativelygo build ./internal/harness/...passes (no code changes, just documentation)Checklist
!for breaking changes)Closes #6160
Post-script verification
agent/6160-adr-maintenance-step)baecf40956b2cb1250d1946513515a20af4807fc..HEAD)