Repository navigation
docs(adr): add ADR 0086 for conversation surface participation #6083
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
f0fb298
docs(adr): add ADR 0086 for conversation surface participation
ifireball 62739d2
docs(adr): guard optional fields in conversation CEL example
ifireball a3167c2
docs(adr): clarify conversation category.format vs GitHub GraphQL
ifireball f2cbdda
docs(adr): merge main and address conversation ADR review
ifireball dc083a0
chore(normevent): gofmt conversation types
ifireball ccf2212
test(normevent): cover conversation Validate error paths
ifireball 103899b
docs(adr): revise conversation threading to comment parent_id
ifireball 86620b7
docs(adr): note non-numeric conversation entity id follow-on
ifireball a65c62e
docs(adr): merge upstream/main into conversation ADR branch
ifireball File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
126 changes: 126 additions & 0 deletions
126
docs/ADRs/0086-conversation-surface-for-agent-participation.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,126 @@ | ||
| --- | ||
| title: "86. Conversation surface for agent participation" | ||
| status: Accepted | ||
| relates_to: | ||
| - agent-architecture | ||
| - agent-infrastructure | ||
| - security-threat-model | ||
| topics: | ||
| - discussions | ||
| - dispatch | ||
| - conversation | ||
| - tracker | ||
| - portability | ||
| - slash-commands | ||
| --- | ||
|
|
||
| # 86. Conversation surface for agent participation | ||
|
|
||
| Date: 2026-08-11 | ||
|
|
||
| ## Status | ||
|
|
||
| Accepted | ||
|
|
||
| Builds on [ADR 0005](0005-forge-abstraction-layer.md), | ||
| [ADR 0017](0017-credential-isolation-for-sandboxed-agents.md) / | ||
| [ADR 0046](0046-host-side-api-server-design.md), | ||
| [ADR 0054](0054-require-authorization-on-all-agent-dispatch-paths.md), | ||
| [ADR 0058](0058-agent-registration.md), | ||
| [ADR 0061](0061-harness-cel-dispatch.md), | ||
| [ADR 0063](0063-polling-based-work-discovery.md), and | ||
| [ADR 0076](0076-slash-command-entity-context-separation.md). | ||
| Aligns with the `tracker.Client` split | ||
| ([#5988](https://github.com/fullsend-ai/fullsend/issues/5988)): domain | ||
| interfaces stay narrow; `forge.Client` remains git-hosting only. | ||
|
|
||
| ## Context | ||
|
|
||
| Agents already act on forge **work items** and **change proposals** via slash | ||
| commands and host/post-script comments. GitHub Discussions (and later Slack, | ||
| Discord, Matrix, GitLab discussions) are a different surface: threaded community | ||
| conversation that must not be shoehorned into `work_item` without breaking | ||
| entity-context rules ([ADR 0076](0076-slash-command-entity-context-separation.md)). | ||
|
|
||
| `forge.Client` is scoped to git-hosting. Issue content for non-forge backends | ||
| (Jira) already moves to `tracker.Client` rather than expanding the forge | ||
| interface. Slack/Discord/Matrix are likewise not forges — conversation | ||
| read/write must not grow `forge.Client`. | ||
|
|
||
| Discussions also introduce **categories** (partition + format/permission | ||
| policy) distinct from **labels** (multi-tag triage). The event model must | ||
| expose both without collapsing them. | ||
|
|
||
| ## Options | ||
|
|
||
| ### A. Special-case GitHub Discussions in workflows | ||
|
|
||
| Fastest for GitHub; GitHub-centric and duplicates auth/writeback. | ||
|
|
||
| ### B. Always-on chat bot outside the execution stack | ||
|
|
||
| Low latency; bypasses unidirectional control, mint/OIDC identity, and harness | ||
| registration ([ADR 0016](0016-unidirectional-control-flow.md)). | ||
|
|
||
| ### C. Extend `forge.Client` with Conversation/Message methods | ||
|
|
||
| Pulls non-forge chat into the forge package and fights the `tracker.Client` | ||
| split. | ||
|
|
||
| ### D. Portable Conversation surface via `conversation.Client` (chosen) | ||
|
|
||
| Parallel to `tracker.Client`: narrow domain interface + dispatch/event reuse, | ||
| with per-backend adapters. | ||
|
|
||
| ## Decision | ||
|
|
||
| Adopt **Option D**. | ||
|
|
||
| ### Domain model | ||
|
|
||
| | Relation | Cardinality | Notes | | ||
| |----------|-------------|--------| | ||
| | Category → Conversation | **1:M** | Every conversation has exactly one category (GitHub requires it; Slack/Discord map channel → category). | | ||
| | Conversation ↔ Label | **M:M** | Same triage tags as issues when the backend supports them (GitHub Discussions do). | | ||
| | Conversation → Message | **1:M** | Messages (comments/replies) belong to one conversation. | | ||
| | Message → Category / Label | **none** | Messages inherit routing context from their parent conversation; they are not categorized or labeled independently. | | ||
|
|
||
| **Category ≠ label.** Categories are a single exclusive partition with | ||
| backend-defined format/permission semantics (e.g. GitHub announcement = | ||
| maintain/admin create; Q&A = answerable). Labels are additive tags on the | ||
| conversation. Adapters must not encode the category name as a synthetic label. | ||
|
|
||
| **Permissions.** Platform authorization remains | ||
| [ADR 0054](0054-require-authorization-on-all-agent-dispatch-paths.md) (effective | ||
| repo/collaborator role on `actor`). Category format is **routing and policy | ||
| metadata** for harness CEL (e.g. only vouch agents match | ||
| `category.slug == "vouch-request"`), not a second auth system. Backends may | ||
|
ifireball marked this conversation as resolved.
Resolved
|
||
| still reject creates/replies the actor cannot perform; that is adapter error | ||
| handling. | ||
|
|
||
| ### Architecture seams | ||
|
|
||
| 1. **`conversation.Client`:** `internal/conversation` with Conversation/Message | ||
| APIs (and category metadata on Conversation). GitHub Discussions first; | ||
| Slack/peers implement directly. **Not** on `forge.Client` or | ||
| `tracker.Client`. | ||
| 2. **`NormalizedEvent`:** `entity.kind: conversation`. Require | ||
| `state.conversation.category` (`name` required; `id`/`slug`/`format` | ||
| optional). Reuse `state.labels` for conversation labels only. Message | ||
| events use `transition.kind: comment_added` with `transition.comment`; | ||
| category and labels still describe the **parent conversation**. See | ||
| [normative v1](../normative/normalized-event/v1/). | ||
| 3. **Ingress / egress / identity / security:** shim + dispatch drivers; | ||
| host-mediated writeback via `conversation.Client` (tier 1 default, host API | ||
| for mid-run); least-privilege Discussions/chat scopes; conversation bodies | ||
| untrusted; entity-context rules keep code-mutating slash commands off | ||
| conversations ([ADR 0076](0076-slash-command-entity-context-separation.md)). | ||
|
|
||
| ## Consequences | ||
|
|
||
| - Harnesses route with CEL on both `state.conversation.category` and | ||
| `state.labels` (e.g. category selects the agent; labels refine). | ||
| - Slack becomes input-driver + `conversation.Client` adapter work; channel maps | ||
| to category, thread maps to conversation. | ||
| - Domain split: `forge.Client` / `tracker.Client` / `conversation.Client`. | ||
| - Linking a conversation to a work item for `/fs-code` remains a follow-on. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
38 changes: 38 additions & 0 deletions
38
docs/normative/normalized-event/v1/examples/discussion-fs-vouch-comment.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| { | ||
| "repo": "fullsend-ai/fullsend", | ||
| "entity": { | ||
|
ifireball marked this conversation as resolved.
Resolved
|
||
| "kind": "conversation", | ||
| "id": 5182, | ||
| "url": "https://github.com/fullsend-ai/fullsend/discussions/5182" | ||
| }, | ||
| "actor": { | ||
| "id": "contributor", | ||
| "kind": "human", | ||
| "role": "write", | ||
| "is_entity_author": true | ||
| }, | ||
| "transition": { | ||
| "kind": "comment_added", | ||
| "comment": { | ||
| "command": "/fs-vouch", | ||
| "body": "/fs-vouch please review my request", | ||
| "instruction": "please review my request" | ||
| } | ||
| }, | ||
| "state": { | ||
| "labels": ["needs-triage"], | ||
| "conversation": { | ||
| "category": { | ||
| "id": "DIC_kwDOExample", | ||
| "name": "Vouch Request", | ||
| "slug": "vouch-request", | ||
| "format": "discussion" | ||
| } | ||
| } | ||
| }, | ||
| "source": { | ||
| "system": "github", | ||
| "raw_type": "discussion_comment", | ||
| "raw_action": "created" | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.