Skip to content

docs(#5954): link per-repo config header to user-facing docs - #5956

Merged
rh-hemartin merged 1 commit into
mainfrom
agent/5954-config-header-link
Aug 27, 2026
Merged

docs(#5954): link per-repo config header to user-facing docs#5956
rh-hemartin merged 1 commit into
mainfrom
agent/5954-config-header-link

Conversation

@fullsend-ai-coder

Copy link
Copy Markdown
Contributor

Summary

Replace the bare "ADR 0033" reference in the generated per-repo .fullsend/config.yaml header with a direct link to the published user-facing documentation at https://fullsend.sh/docs/guides/infrastructure/layered-config-reference.

Related Issue

Closes #5954

Changes

  • Update perRepoConfigHeader in internal/config/config.go to replace the internal ADR citation with the published docs URL
  • Add TestPerRepoConfigHeaderPointsToUserDocs regression test asserting the header links to user-facing docs and does not reference internal ADRs

Testing

  • go test ./internal/config/... passes
  • New test TestPerRepoConfigHeaderPointsToUserDocs added and passing
  • go vet ./internal/config/... passes
  • Secret scan passes

Closes #5954

Post-script verification

  • Branch is not main/master (agent/5954-config-header-link)
  • Secret scan passed (gitleaks — 900d4f429bf350a5a86701d97c08af848d48caf5..HEAD)
  • PR body secret scan passed (gitleaks — no-git)

@fullsend-ai-coder
fullsend-ai-coder Bot requested a review from a team as a code owner August 5, 2026 20:08
@fullsend-ai-coder fullsend-ai-coder Bot added the ready-for-review Triggers review agent dispatch label Aug 5, 2026
@fullsend-ai-review

fullsend-ai-review Bot commented Aug 5, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 8:09 PM UTC · Completed 8:18 PM UTC
Commit: 7833d85 · View workflow run →

@codecov

codecov Bot commented Aug 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@fullsend-ai-review

fullsend-ai-review Bot commented Aug 5, 2026

Copy link
Copy Markdown

Review

Findings

Low

  • [stale-reference] .fullsend/config.yaml:5 — The repo’s own .fullsend/config.yaml still contains the old header text # See ADR 0033 for details. — the exact wording this PR removes from the perRepoConfigHeader template. After this PR, newly generated config files will have the updated header pointing to the user-facing docs, but this existing committed config file retains the stale ADR reference.
    Remediation: Update the header comment in .fullsend/config.yaml line 5 to match the new perRepoConfigHeader template.
Previous run

Looks good to me

fullsend-ai-review[bot]

This comment was marked as outdated.

@rh-hemartin

Copy link
Copy Markdown
Member

/fs-fix rebase and resolve conflicts

@fullsend-ai-coder

fullsend-ai-coder Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor Author

🤖 Finished Fix · ❌ Failure (post-script /home/runner/work/fullsend/fullsend/.fullsend/.fullsend-cache/resources/sha256/1704f826be06352c5aa727ca7a68e6bc3db1837e9743e1727323664169eefe2b/scripts/post-fix.sh failed: exit status 1) · Started 7:15 AM UTC · Completed 7:21 AM UTC

Commit: 7833d85 · View workflow run →

Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $1.15

@fullsend-ai-coder

Copy link
Copy Markdown
Contributor Author

⚠️ Post-fix script failed — Secret scan blocked (exit code 1)

The fix agent completed, but the post-fix script failed before finishing.

Workflow run: https://github.com/fullsend-ai/fullsend/actions/runs/32941698772

Details:
Secret scan blocked the push. See workflow logs for details.
Please check the workflow logs for full details and retry with /fs-fix if appropriate.

The perRepoConfigHeader constant referenced "ADR 0033" — an
internal design record with no link. Users reading their
generated .fullsend/config.yaml had no way to find it, and
ADRs are written for maintainers, not end users.

Replace the bare ADR reference with a direct URL to the
published layered-config-reference guide on fullsend.sh.
Add a regression test asserting the header links to
user-facing docs and does not cite internal ADRs.

Closes #5954

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@rh-hemartin
rh-hemartin enabled auto-merge August 27, 2026 06:58
@fullsend-ai-review

fullsend-ai-review Bot commented Aug 27, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 7:00 AM UTC · Completed 7:14 AM UTC

Commit: 257f41d · View workflow run →

Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $3.82

@rh-hemartin
rh-hemartin added this pull request to the merge queue Aug 27, 2026
@fullsend-ai-review fullsend-ai-review Bot added the risk/moderate PR risk: moderate label Aug 27, 2026
@fullsend-ai-review

Copy link
Copy Markdown

Risk Assessment: moderate (2/5)

Details

Tiny documentation-only comment change replacing an ADR reference with a user-facing docs URL, elevated to moderate solely because the target files are high-churn hotspots with many recent authors and fix commits.

Merged via the queue into main with commit c9a9622 Aug 27, 2026
43 checks passed
@rh-hemartin
rh-hemartin deleted the agent/5954-config-header-link branch August 27, 2026 07:21
@fullsend-ai-retro

fullsend-ai-retro Bot commented Aug 27, 2026

Copy link
Copy Markdown

🤖 Finished Retro · ✅ Success · Started 7:23 AM UTC · Completed 7:33 AM UTC

Commit: 257f41d · View workflow run →

Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $5.37

@fullsend-ai-retro

Copy link
Copy Markdown

Retro: PR #5956 — link per-repo config header to user-facing docs

Workflow: Issue #5954 → triage → code agent → review → (21-day wait) → human /fs-fix rebase → fix agent failure → human force-push → re-review → merge.

Agents repo: fullsend-ai/agents@main (commit 19f8eaba9d48).

What went well

  • Code agent produced correct, minimal, well-tested code on the first attempt (2 files, 8 additions, 10 deletions, regression test included). Zero rework iterations on the code itself.
  • Review agent caught a real issue: the repo's own .fullsend/config.yaml:5 still contains the stale # See ADR 0033 for details. header that the PR was removing from the template. This was a genuine completeness gap in the code agent's work.
  • CI passed cleanly on every push. Codecov confirmed full patch coverage.

Evidence for existing open issues

  • fix(ci): post-fix gitleaks scan false-positives when fix agent merges or rebases main #6259 (post-fix gitleaks false-positives on rebase): This PR is another instance of the exact bug. The fix agent successfully rebased the branch (run 32941698772), but SCAN_RANGE used PRE_AGENT_HEAD (7833d85), which is no longer an ancestor after rebase. Gitleaks scanned 744 commits and found 6 pre-existing false-positive leaks, blocking the push. Cost: $1.15 wasted, plus the human had to manually force-push the same rebased commit the next day.
  • Skip re-review when PR diff is unchanged after rebase/reopen #1356 (skip re-review when PR diff is unchanged after rebase/reopen): After the human force-pushed the rebased commit (identical diff, just rebased onto current main), the review agent ran a full re-review costing $3.82 and produced the same finding as the original review. The diff content was unchanged.
  • Auto-file tracking issues for unresolved low-severity review findings #1286 (auto-file tracking issues for unresolved low-severity review findings): The review agent correctly identified the stale .fullsend/config.yaml reference as a Low-severity finding, approved the PR, and the PR was merged without addressing it. No follow-up issue was filed. The stale reference remains in the repo today.

No new proposals

All significant findings from this workflow are already covered by open issues. The workflow was clean overall — the code agent got it right on the first try, the review agent caught a real gap, and the only friction came from the known post-fix gitleaks rebase bug (#6259).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-merge All reviewers approved — ready to merge ready-for-review Triggers review agent dispatch risk/moderate PR risk: moderate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: per-repo config.yaml header cites "ADR 0033" with no link, and ADRs aren't user-facing

1 participant