docs(#5954): link per-repo config header to user-facing docs - #5956
Conversation
|
🤖 Finished Review · ✅ Success · Started 8:09 PM UTC · Completed 8:18 PM UTC |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
ReviewFindingsLow
Previous runLooks good to me |
|
/fs-fix rebase and resolve conflicts |
|
🤖 Finished Fix · ❌ Failure (post-script /home/runner/work/fullsend/fullsend/.fullsend/.fullsend-cache/resources/sha256/1704f826be06352c5aa727ca7a68e6bc3db1837e9743e1727323664169eefe2b/scripts/post-fix.sh failed: exit status 1) · Started 7:15 AM UTC · Completed 7:21 AM UTC Commit: Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $1.15 |
|
The fix agent completed, but the post-fix script failed before finishing. Workflow run: https://github.com/fullsend-ai/fullsend/actions/runs/32941698772 Details: |
The perRepoConfigHeader constant referenced "ADR 0033" — an internal design record with no link. Users reading their generated .fullsend/config.yaml had no way to find it, and ADRs are written for maintainers, not end users. Replace the bare ADR reference with a direct URL to the published layered-config-reference guide on fullsend.sh. Add a regression test asserting the header links to user-facing docs and does not cite internal ADRs. Closes #5954 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
7833d85 to
257f41d
Compare
|
🤖 Finished Review · ✅ Success · Started 7:00 AM UTC · Completed 7:14 AM UTC Commit: Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $3.82 |
|
Risk Assessment: moderate (2/5) DetailsTiny documentation-only comment change replacing an ADR reference with a user-facing docs URL, elevated to moderate solely because the target files are high-churn hotspots with many recent authors and fix commits. |
|
🤖 Finished Retro · ✅ Success · Started 7:23 AM UTC · Completed 7:33 AM UTC Commit: Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $5.37 |
Retro: PR #5956 — link per-repo config header to user-facing docsWorkflow: Issue #5954 → triage → code agent → review → (21-day wait) → human Agents repo: What went well
Evidence for existing open issues
No new proposalsAll significant findings from this workflow are already covered by open issues. The workflow was clean overall — the code agent got it right on the first try, the review agent caught a real gap, and the only friction came from the known post-fix gitleaks rebase bug (#6259). |
Summary
Replace the bare "ADR 0033" reference in the generated per-repo
.fullsend/config.yamlheader with a direct link to the published user-facing documentation athttps://fullsend.sh/docs/guides/infrastructure/layered-config-reference.Related Issue
Closes #5954
Changes
perRepoConfigHeaderininternal/config/config.goto replace the internal ADR citation with the published docs URLTestPerRepoConfigHeaderPointsToUserDocsregression test asserting the header links to user-facing docs and does not reference internal ADRsTesting
go test ./internal/config/...passesTestPerRepoConfigHeaderPointsToUserDocsadded and passinggo vet ./internal/config/...passesCloses #5954
Post-script verification
agent/5954-config-header-link)900d4f429bf350a5a86701d97c08af848d48caf5..HEAD)