chore(#5824): remove CUSTOM_BASE overlay loop from reusable workflows by ggallen · Pull Request #5836 · fullsend-ai/fullsend

ggallen · 2026-08-02T11:45:02Z

Summary

Remove the CUSTOM_BASE overlay loop from all 6 reusable workflows (triage, code, review, fix, retro, prioritize) and the prepare-workspace composite action
Remove the customized/scripts overlay from the scaffold repo-maintenance.yml template
Update scaffold test to assert the overlay is absent
Update implementation plan to reflect PR 2 completion
The overlay ran every agent invocation but copied zero files — all customized/ directories contain only .gitkeep placeholders

Test plan

grep -r 'CUSTOM_BASE' .github/workflows/reusable-*.yml .github/actions/prepare-workspace/action.yml returns no matches
grep -r 'customized/' internal/scaffold/fullsend-repo/.github/workflows/repo-maintenance.yml returns no matches
All pre-commit hooks pass (YAML lint, actionlint, workflow file size)
TestRepoMaintenanceWorkflowContent updated to assert overlay is removed
CI passes on this PR

Part of #5824

🤖 Generated with Claude Code

qodo-code-review · 2026-08-02T11:45:56Z

PR Summary by Qodo

Remove unused customized/ overlay logic from GitHub workflows and scaffolds

⚙️ Configuration changes ✨ Enhancement 🕐 10-20 Minutes

AI Description

• Remove CUSTOM_BASE overlay loop from reusable workflows and prepare-workspace action.
• Drop customized/scripts overlay from the scaffold repo-maintenance.yml template.
• Simplify agent/workspace setup per ADR-0064 (overlay copied no real files).

Diagram

graph TD
  A["Reusable workflows"] --> B["prepare-workspace action"] --> C["Prepared workspace"]
  E["Scaffold template"] --> F["repo-maintenance workflow"] --> C
  B -. "overlay removed" .-> D["customized/ dirs"]
  F -. "overlay removed" .-> D

High-Level Assessment

The following are alternative approaches to this PR:

1. Keep overlay support but gate on non-.gitkeep content

➕ Preserves a customization hook for future use without always paying the cost
➕ Avoids reintroducing logic if overlays become needed again
➖ Still carries extra complexity and filesystem traversal in critical setup paths
➖ Encourages an undocumented/rarely-used extension point rather than a supported mechanism

2. Replace overlays with a single explicit hook step (e.g., run script if present)

➕ Clearer contract: one optional entrypoint rather than directory mirroring
➕ Less error-prone than copying arbitrary trees into the workspace
➖ Requires designing and documenting a new customization interface
➖ May not cover file-overlay use cases if they later become real

Recommendation: Proceed with the PR’s approach. Given ADR-0064 and the fact that current customized/ trees contain only .gitkeep, removing the overlay loops reduces repeated filesystem work and configuration surface area across all agent entrypoints. If customization is needed later, prefer an explicit, documented hook (script/step) rather than implicit directory overlays.

Files changed (8) +0 / -106

Other (8) +0 / -106

action.ymlRemove CUSTOM_BASE overlay copy loop from workspace preparation +0/-14

Remove CUSTOM_BASE overlay copy loop from workspace preparation
• Deletes the per-invocation logic that searched 'customized/' or '.fullsend/customized/' for overlay files and copied them into the destination workspace. Keeps the layered directory copy and script setup intact.
.github/actions/prepare-workspace/action.yml

reusable-code.ymlDrop customized overlay step from reusable code workflow setup +0/-14

Drop customized overlay step from reusable code workflow setup

• Removes the 'CUSTOM_BASE' overlay traversal and copy logic from the workflow’s workspace preparation script block. The workflow continues to copy layered directories and install setup scripts without overlay behavior.

.github/workflows/reusable-code.yml

reusable-fix.ymlDrop customized overlay step from reusable fix workflow setup +0/-14

Drop customized overlay step from reusable fix workflow setup
• Eliminates the overlay copy loop that attempted to merge files from 'customized/' into the working directory. Leaves the standard layered copy and script initialization flow unchanged.
.github/workflows/reusable-fix.yml

reusable-prioritize.ymlDrop customized overlay step from reusable prioritize workflow setup +0/-14

Drop customized overlay step from reusable prioritize workflow setup
• Removes logic that conditionally copied non-'.gitkeep' files from 'customized/' overlays into the destination. The remaining setup continues to populate '.github/scripts' from the source layer.
.github/workflows/reusable-prioritize.yml

reusable-retro.ymlDrop customized overlay step from reusable retro workflow setup +0/-14

Drop customized overlay step from reusable retro workflow setup
• Deletes the block that iterated layered dirs under 'CUSTOM_BASE' and copied discovered files into the workspace. Retains the baseline layered copy behavior and setup script installation.
.github/workflows/reusable-retro.yml

reusable-review.ymlDrop customized overlay step from reusable review workflow setup +0/-14

Drop customized overlay step from reusable review workflow setup
• Removes the 'CUSTOM_BASE' selection and 'find | cp' loop used to apply overlays. The workflow now only performs the standard layered directory copy and script setup.
.github/workflows/reusable-review.yml

reusable-triage.ymlDrop customized overlay step from reusable triage workflow setup +0/-14

Drop customized overlay step from reusable triage workflow setup
• Removes the overlay file-copy logic that previously ran after copying layered directories. Keeps the rest of the workspace preparation steps as-is.
.github/workflows/reusable-triage.yml

repo-maintenance.ymlRemove customized/scripts overlay from scaffold repo-maintenance template +0/-8

Remove customized/scripts overlay from scaffold repo-maintenance template
• Deletes the conditional copy of 'customized/scripts' into the generated repo during scaffold setup. The template now only copies scripts from the scaffold defaults and cleans up '.defaults'.
internal/scaffold/fullsend-repo/.github/workflows/repo-maintenance.yml

fullsend-ai-review · 2026-08-02T11:46:02Z

🤖 Finished Review · ✅ Success · Started 11:46 AM UTC · Completed 12:03 PM UTC
Commit: 557808e · View workflow run →

qodo-code-review · 2026-08-02T11:48:20Z

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📜 Skill insights (0)

1. ~~Stale scaffold test assertion~~ ✓ Resolved 🐞 Bug ≡ Correctness

Description

TestRepoMaintenanceWorkflowContent still asserts repo-maintenance.yml contains "customized/scripts",
but this PR removes that overlay block so the test will fail deterministically. This breaks CI/unit
tests and leaves scaffold expectations out of sync with the template.

Code

internal/scaffold/fullsend-repo/.github/workflows/repo-maintenance.yml[L57-60]

-          if [[ -d "customized/scripts" ]]; then
-            find "customized/scripts" -type f ! -name '.gitkeep' -print0 \
-              | while IFS= read -r -d '' f; do
-                  rel="${f#customized/}"

Relevance

●●● Strong
Scaffold/template changes are typically paired with updating scaffold tests to match; similar
test-sync fixes accepted.
PR-#5555
PR-#792

ⓘ Recommendations generated based on similar findings in past PRs

Evidence
The embedded scaffold workflow no longer contains any customized/scripts overlay logic, but the
scaffold test still requires that substring to exist in the workflow content.
internal/scaffold/fullsend-repo/.github/workflows/repo-maintenance.yml[51-58]
internal/scaffold/scaffold_test.go[772-790]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

### Issue description
The scaffolded `repo-maintenance.yml` template no longer contains the `customized/scripts` overlay, but `internal/scaffold/scaffold_test.go` still asserts that string is present, causing unit tests to fail.

### Issue Context
This PR intentionally removes the overlay logic; the corresponding scaffold content test needs to be updated to match the new template behavior.

### Fix Focus Areas
- internal/scaffold/scaffold_test.go[772-790]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

2. ~~Docs still promise overlay~~ ✗ Dismissed 🐞 Bug ⚙ Maintainability

Description

User docs and embedded comments still state that reusable workflows copy/overlay customized/ files
at runtime, but this PR removes that overlay logic so those instructions are now incorrect. This can
lead users to place overrides in customized/ that will be silently ignored.

Code

.github/actions/prepare-workspace/action.yml[L46-49]

-        CUSTOM_BASE="customized"
-        if [[ "${INSTALL_MODE}" == "per-repo" ]]; then
-          CUSTOM_BASE=".fullsend/customized"
-        fi

Relevance

●●● Strong
Team commonly fixes doc drift when behavior/ADR changes; customized/ deprecation/docs updates
previously accepted.
PR-#5462

ⓘ Recommendations generated based on similar findings in past PRs

Evidence
The prepare-workspace action no longer performs any customized overlay copying, while docs and
comments explicitly describe that overlay as part of runtime behavior and customization layering.
.github/actions/prepare-workspace/action.yml[24-47]
docs/guides/user/customizing-agents.md[250-298]
internal/scaffold/fullsend-repo/scripts/.pre-commit-tools.yaml[35-45]
docs/guides/user/building-custom-agents.md[160-178]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

### Issue description
The PR removes the `CUSTOM_BASE`/`customized/` runtime overlay mechanism, but several docs and scaffold comments still describe it as active behavior and recommend paths under `customized/` / `.fullsend/customized/`.

### Issue Context
Now that the overlay loops are removed, documentation should either (a) remove these instructions, or (b) clearly mark them as historical/deprecated and point to the replacement mechanisms (e.g., `base:` harness composition, URL references, config-based agent registration, L2 `.pre-commit-tools.yaml` merge).

### Fix Focus Areas
- docs/guides/user/customizing-agents.md[250-298]
- docs/guides/user/building-custom-agents.md[160-178]
- internal/scaffold/fullsend-repo/scripts/.pre-commit-tools.yaml[35-45]
- .github/actions/prepare-workspace/action.yml[24-47]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Context used

✅ Compliance rules (platform): 61 rules

✅ Skills: writing-user-docs, writing-adrs

_{To customize comments, go to the Qodo configuration screen, or learn more in the docs.}

fullsend-ai-review · 2026-08-02T12:03:41Z

Review

Findings

Medium

[protected-path] This PR modifies 7 files under .github/ (actions/prepare-workspace/action.yml and 6 reusable workflows). These are governance/infrastructure files that require human approval. The PR links to issue Remove customized/ directory overlay mechanism (ADR-0064) #5824 and provides rationale (removal of deprecated CUSTOM_BASE overlay per ADR-0064). Human approval is always required for protected-path changes.

Previous run

Review

Findings

High

[dependency-violation] .github/actions/prepare-workspace/action.yml — Issue Remove customized/ directory overlay mechanism (ADR-0064) #5824 explicitly states "Depends on PR chore(#5694): remove deprecated customized/ scaffold #5697 (removes scaffold Go code, embedded directories, and test assertions)" and PR chore(#5694): remove deprecated customized/ scaffold #5697 is currently open. The issue carries the blocked label. While the code changes themselves are safe — the overlay loop removal is independent of the scaffold Go code removal, correctness review confirms no stale references, and security review confirms removal reduces attack surface — the issue author established this ordering constraint.
Remediation: Confirm with the issue author that this PR can merge before PR chore(#5694): remove deprecated customized/ scaffold #5697, or wait for PR chore(#5694): remove deprecated customized/ scaffold #5697 to merge first.

Medium

[protected-path] This PR modifies 7 files under .github/ (actions/prepare-workspace/action.yml and 6 reusable workflows). These are governance/infrastructure files that require human approval. The PR links to issue Remove customized/ directory overlay mechanism (ADR-0064) #5824 and provides rationale (removal of deprecated CUSTOM_BASE overlay per ADR-0064). Human approval is always required for protected-path changes.
[scope-creep] PR body states "Closes Remove customized/ directory overlay mechanism (ADR-0064) #5824", but issue Remove customized/ directory overlay mechanism (ADR-0064) #5824 tracks the entire ADR-0064 removal work — a 5-PR sequence including scaffold code removal (PR 3), doc updates (PR 4), and grep sweep (PR 5). Closing the issue now would hide remaining work.
Remediation: Change "Closes Remove customized/ directory overlay mechanism (ADR-0064) #5824" to "Part of Remove customized/ directory overlay mechanism (ADR-0064) #5824".
[misleading-instructions] docs/guides/user/customizing-agents.md:7 — References .fullsend/customized/harness/ as a file location, but the overlay loop is removed by this PR. File already has a deprecation notice (lines 152-160). Doc cleanup is scheduled as PR 4 per the implementation plan.
[misleading-instructions] docs/guides/user/building-custom-agents.md:31 — Shows .fullsend/customized/ as the directory structure for custom agents. Lines 2-7 have a deprecation notice. Doc cleanup is scheduled as PR 4.

Low

[stale-implementation-plan] docs/plans/deprecate-customized-directory-overlay.md:95 — Plan describes PR 2 as future work; update to reflect completion after merge.
[misleading-instructions] docs/guides/user/customizing-with-skills.md:124 — Describes customized/ overlay; deprecation notice at lines 119-121. Scheduled for PR 4.
[stale-example] docs/guides/user/building-custom-agents.md:484 — Example shows CUSTOM_BASE overlay loop code. Guide deprecated per lines 2-7. Scheduled for PR 4.
[stale-cross-reference] docs/guides/user/customizing-with-agents-md.md:122 — Links to customized/skills/ with "(deprecated)" annotation. Scheduled for PR 4.

Labels: PR modifies CI workflows and actions under .github/, title uses chore() prefix per ADR-0064 deprecation work

Next steps:

/fs-fix — agent addresses review findings automatically
/fs-fix <your instruction> — agent fixes with your specific guidance
Push commits directly — review re-runs automatically on push
/fs-fix-stop — disable automatic fix runs for this PR

…e workflows Remove the CUSTOM_BASE overlay loop from all reusable workflows, the prepare-workspace composite action, and the scaffold repo-maintenance workflow template. The overlay copies zero files — all customized/ directories contain only .gitkeep placeholders. Update scaffold test to assert the overlay is absent and mark PR 2 as complete in the implementation plan. Signed-off-by: Greg Allen <gallen@redhat.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Greg Allen <gallen@redhat.com>

fullsend-ai-review · 2026-08-02T12:17:31Z

🤖 Review · ❌ Terminated · Started 12:17 PM UTC · Ended 12:30 PM UTC
Commit: 3d1c982 · View workflow run →

github-actions · 2026-08-02T12:18:45Z

Site preview

Preview: https://3d04ac8d-site.fullsend-ai.workers.dev

Commit: 3d1c982b3c56c0dfb0ecb141766c5c8a7f1688c9

codecov · 2026-08-02T12:19:59Z

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Superseded by updated review

fullsend-ai-review · 2026-08-02T12:30:45Z

🤖 Finished Review · ✅ Success · Started 12:17 PM UTC · Completed 12:30 PM UTC
Commit: 3d1c982 · View workflow run →

ggallen · 2026-08-03T01:54:57Z

@rh-hemartin, you reviewed #5697 which is the first part of the removal. This is the second and final part. Do you want to review this as well.

fullsend-ai-retro · 2026-08-04T18:47:18Z

🤖 Finished Retro · ✅ Success · Started 6:47 PM UTC · Completed 7:02 PM UTC
Commit: 3d1c982 · View workflow run →

fullsend-ai-retro · 2026-08-04T19:02:43Z

Retro: PR #5836 — Remove CUSTOM_BASE overlay loop

Timeline: PR opened 2026-08-02 by ggallen (human-authored, Claude Opus 4.6 co-author). Review bot ran twice (on open and after force push). Two human approvals (rh-hemartin, ascerra). Merged 2026-08-04 via merge queue. 2 review dispatches + 1 retro dispatch — efficient workflow with no wasted fix/code runs.

What went well:

Review agent correctly caught a HIGH dependency-violation (issue Remove customized/ directory overlay mechanism (ADR-0064) #5824 depended on open PR chore(#5694): remove deprecated customized/ scaffold #5697), MEDIUM scope-creep ("Closes Remove customized/ directory overlay mechanism (ADR-0064) #5824" should be "Part of Remove customized/ directory overlay mechanism (ADR-0064) #5824"), and protected-path governance requiring human approval. All actionable findings were resolved before merge.
Qodo bot independently caught a stale test assertion bug, which the author fixed in the force push before the review bot's second run.
Re-review after force push correctly resolved fixed findings and dismissed the stale review. Only the inherent protected-path finding remained.
Workflow was efficient: 2 review runs, no unnecessary fix dispatches, clean merge queue passage.

Key gap — plan prerequisite validation:
Human reviewer waynesun09 identified the most substantive issue: the implementation plan (docs/plans/deprecate-customized-directory-overlay.md) defines a dependency chain where PR 1 (add deprecation warnings) must land before PR 2 (remove overlay). PR 1 was never implemented, but this PR (PR 2) proceeded to hard removal. The review bot read the plan (proved by its LOW stale-implementation-plan finding on line 95) but treated it as passive documentation rather than an active contract with enforceable prerequisites. The author responded that users were notified via Slack on July 20, which the human approvers accepted.

Existing issue notes:

Review agent should flag unchecked test plan items on infrastructure PRs #3763 (flag unchecked test plan items) and Correctness sub-agent should compare new interface signatures against referenced design documents #4054 (compare interface signatures against design docs) are adjacent but do not cover implementation plan prerequisite chain validation.
Add AGENTS.md guidance that implementation plan docs are historical records #2948 (treat plan docs as historical records) applies to completed plans; it does not conflict with validating prerequisite chains in plans that are actively being executed (i.e., where a PR is marking a step as done).

Proposals filed

Review agent should validate implementation plan prerequisite chains (in fullsend-ai/agents)

Remove the fullsend agent migrate-customizations command, which became dead code after the customized/ directory overlay mechanism was fully removed (PRs #5697 and #5836). With no overlay to migrate from, the command has nothing meaningful to do. - Delete internal/cli/migrate.go and internal/cli/migrate_test.go - Remove subcommand registration from internal/cli/agent.go - Update agent_test.go assertion and add negative assertion - Remove CLI reference documentation and migration guidance - Remove stale migrate.go references from docs - Annotate cross-references in ADRs to note the command's removal BREAKING CHANGE: The `fullsend agent migrate-customizations` CLI command has been removed. Users who have already migrated to config-driven agents are unaffected. Closes #5864 Signed-off-by: Claude <noreply@anthropic.com> Signed-off-by: Greg Allen <gallen@redhat.com>

ggallen requested a review from a team as a code owner August 2, 2026 11:45

ggallen changed the title ~~chore(#5824): remove customized/ directory overlay mechanism (ADR-0064)~~ chore(#5824): remove CUSTOM_BASE overlay loop from reusable workflows Aug 2, 2026

qodo-code-review Bot reviewed Aug 2, 2026

View reviewed changes

Comment thread internal/scaffold/fullsend-repo/.github/workflows/repo-maintenance.yml

Comment thread .github/actions/prepare-workspace/action.yml

This comment was marked as outdated.

Sign in to view

fullsend-ai-review Bot added component/ci CI pipelines and checks type/chore Maintenance and housekeeping tasks labels Aug 2, 2026

ggallen force-pushed the worktree-5824-remove-custom-base-overlay branch from 557808e to 3d1c982 Compare August 2, 2026 12:16

github-actions Bot deployed to site-preview August 2, 2026 12:18 View deployment

fullsend-ai-review Bot added the requires-manual-review Review requires human judgment label Aug 2, 2026

rh-hemartin approved these changes Aug 3, 2026

View reviewed changes

waynesun09 reviewed Aug 3, 2026

View reviewed changes

Comment thread docs/plans/deprecate-customized-directory-overlay.md

ggallen mentioned this pull request Aug 3, 2026

feat(#5858): add Policy field to ForgeConfig #5859

Merged

6 tasks

fullsend-ai-triage Bot mentioned this pull request Aug 3, 2026

Remove customized/ directory overlay mechanism (ADR-0064) #5824

Closed

ggallen mentioned this pull request Aug 3, 2026

Remove fullsend agent migrate-customizations command (ADR-0064 cleanup) #5864

Closed

fullsend-ai-coder Bot mentioned this pull request Aug 3, 2026

chore(#5864)!: remove migrate-customizations command #5866

Merged

7 tasks

ascerra approved these changes Aug 4, 2026

View reviewed changes

ggallen added this pull request to the merge queue Aug 4, 2026

Merged via the queue into fullsend-ai:main with commit f2cfdf7 Aug 4, 2026
26 checks passed

ggallen deleted the worktree-5824-remove-custom-base-overlay branch August 4, 2026 18:45

fullsend-ai-retro Bot mentioned this pull request Aug 4, 2026

Review agent should validate implementation plan prerequisite chains fullsend-ai/agents#654

Open

fullsend-ai-retro Bot mentioned this pull request Aug 4, 2026

chore(#5694): remove deprecated customized/ scaffold #5697

Merged

11 tasks

ggallen mentioned this pull request Aug 5, 2026

Remove stale customized/ directory references from user-facing docs #5952

Closed

fullsend-ai-coder Bot mentioned this pull request Aug 5, 2026

docs(#5952): remove stale customized/ directory references #5955

Merged

10 tasks

Uh oh!

Conversation

ggallen commented Aug 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Uh oh!

qodo-code-review Bot commented Aug 2, 2026

PR Summary by Qodo

Uh oh!

fullsend-ai-review Bot commented Aug 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

qodo-code-review Bot commented Aug 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review by Qodo

Uh oh!

Uh oh!

Uh oh!

fullsend-ai-review Bot commented Aug 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review

Findings

Medium

Review

Findings

High

Medium

Low

Uh oh!

This comment was marked as outdated.

Uh oh!

fullsend-ai-review Bot commented Aug 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Aug 2, 2026

Site preview

Uh oh!

codecov Bot commented Aug 2, 2026

Codecov Report

Uh oh!

fullsend-ai-review Bot commented Aug 2, 2026

Uh oh!

ggallen commented Aug 3, 2026

Uh oh!

Uh oh!

Uh oh!

fullsend-ai-retro Bot commented Aug 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fullsend-ai-retro Bot commented Aug 4, 2026

Retro: PR #5836 — Remove CUSTOM_BASE overlay loop

Proposals filed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ggallen commented Aug 2, 2026 •

edited

Loading

fullsend-ai-review Bot commented Aug 2, 2026 •

edited

Loading

qodo-code-review Bot commented Aug 2, 2026 •

edited

Loading

fullsend-ai-review Bot commented Aug 2, 2026 •

edited

Loading

fullsend-ai-review Bot commented Aug 2, 2026 •

edited

Loading

fullsend-ai-retro Bot commented Aug 4, 2026 •

edited

Loading