fix(#5731): use github-releases datasource for OpenShell - #5749
Conversation
Change the OpenShell custom manager datasource from github-tags to github-releases so Renovate only proposes updates for tags that have a published GitHub release. Several NVIDIA/OpenShell tags (e.g. v0.0.94, v0.0.93) have no release, causing Renovate to suggest bumps to unpublished versions. Also update the inline renovate annotation comment in openshell-version.sh for consistency. Closes #5731
|
🤖 Finished Review · ✅ Success · Started 6:21 AM UTC · Completed 6:32 AM UTC |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
ReviewFindingsMedium
Labels: PR modifies CI scripts (.github/scripts/) and dependency management config (renovate.json) |
|
🤖 Finished Retro · ✅ Success · Started 6:54 AM UTC · Completed 7:10 AM UTC |
Retro: PR #5749 — use
|
The Dependency Dashboard (fullsend-ai#2682) reported a persistent digest lookup failure for NVIDIA/OpenShell: "Could not determine new digest for update (github-releases package NVIDIA/OpenShell)". Root cause: the customManager tracks OPENSHELL_VERSION with extractVersionTemplate stripping the leading "v" so the value matches the bare-number format stored in the file. Renovate's digest lookup for the github-releases datasource compares that stripped value against raw GitHub tag names (e.g. "v0.0.103"), which never match, so the digest lookup always fails. This is a structural mismatch, not a config typo — the same "v"-stripped + digest-tracking combination would fail for github-tags too, since both share the same findCommitOfTag comparison. PR fullsend-ai#5749 (fixing fullsend-ai#5731) had already moved the datasource from github-tags to github-releases to stop suggesting unreleased tags, but that change didn't address this separate digest issue. Fix: stop asking Renovate to resolve OPENSHELL_SHA as a digest at all. Track only OPENSHELL_VERSION via the customManager, and add a postUpgradeTasks script (scripts/renovate/update-openshell-sha.sh) that looks up the release tag's commit SHA directly and patches it in after each version bump. This mirrors the existing pattern already used for the tirith and cosign version pins in this same file. Also remove the inert "# renovate:" magic comment from openshell-version.sh: no built-in Renovate manager scans .sh files for magic comments, so it did nothing — the customManager's explicit depNameTemplate/datasourceTemplate is what actually drives extraction. Separately, add a packageRule to automerge Docker digest bumps for registry.access.redhat.com/ubi10/* once required checks pass, closing the gap where the existing "patch"/"pin" automerge rule didn't cover digest updates for our UBI base images (evidence for SEC-PATCH-REQ-2). Assisted-by: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Ralph Bean <rbean@redhat.com>
Summary
Change the OpenShell custom manager datasource from
github-tagstogithub-releasesso Renovate only proposes updates for tags that have a published GitHub release. Several NVIDIA/OpenShell tags (e.g. v0.0.94, v0.0.93, v0.0.87) have no release, causing Renovate to suggest bumps to unpublished versions — PR #5597 is a live example.Related Issue
Fixes #5731
Changes
renovate.json: ChangedatasourceTemplatefrom"github-tags"to"github-releases"in the OpenShell custom manager.github/scripts/openshell-version.sh: Update the inline# renovate:annotation comment to match (datasource=github-releases)Testing
make lintpasses (stage changes first, then run)Checklist
!for breaking changes)Closes #5731
Post-script verification
agent/5731-openshell-datasource)e534f24afc2e47097de4d2f68ba2c5b6f1efdce3..HEAD)