-
Notifications
You must be signed in to change notification settings - Fork 105
ci(#5733): pin podman to 4.x to avoid crun incompatibility #5738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| #!/usr/bin/env bash | ||
| # Pin and install podman, working around a crun incompatibility on some | ||
| # runner images. | ||
| # | ||
| # Runner images occasionally pre-install podman 5.x paired with a crun too | ||
| # old to support it, breaking sandbox creation with "crun: unknown version | ||
| # specified". Pin to the 4.x series, which matches the crun shipped on these | ||
| # images, until GitHub Actions runner images ship a compatible crun pairing. | ||
| # `apt-get install -y podman` alone does not downgrade an already-installed | ||
| # newer version, so the pin's Pin-Priority authorizes the downgrade and | ||
| # --allow-downgrades permits apt to execute it. | ||
| # | ||
| # See #5733. Remove this pin once runner images ship crun >= 1.15 | ||
| # (podman 5.x's requirement) as standard. | ||
| # | ||
| # Usage: | ||
| # .github/scripts/install-podman.sh | ||
| set -euo pipefail | ||
|
|
||
| sudo install -d /etc/apt/preferences.d | ||
| printf 'Package: podman\nPin: version 4.*\nPin-Priority: 1001\n' \ | ||
| | sudo tee /etc/apt/preferences.d/podman-pin >/dev/null | ||
| sudo apt-get update | ||
| sudo apt-get install -y --allow-downgrades podman | ||
|
|
||
| installed_version="$(podman --version)" | ||
| case "${installed_version}" in | ||
| *"version 4."*) ;; | ||
| *) | ||
| echo "::error::Failed to pin podman to the 4.x series (see #5733); got: ${installed_version}" | ||
| exit 1 | ||
| ;; | ||
| esac | ||
|
|
||
| echo "${installed_version}" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[low] injection
The ::error:: workflow command and the final echo (line 35) interpolate ${installed_version} (from podman --version) without sanitizing for GHA workflow command sequences. The value originates from a system-installed binary and is not directly attacker-controlled, making this a defense-in-depth observation rather than a practical vulnerability.