fix(#5669): align head_sha schema pattern with CLI regex - #5674
Closed
fullsend-ai-coder[bot] wants to merge 1 commit into
Closed
fix(#5669): align head_sha schema pattern with CLI regex#5674fullsend-ai-coder[bot] wants to merge 1 commit into
fullsend-ai-coder[bot] wants to merge 1 commit into
Conversation
The review-result.schema.json validated head_sha with minLength: 7,
while the CLI (postreview.go) enforces a strict regex requiring 40 or
64 hex characters. This divergence let schema-valid values like
"0000000" pass pre-validation but fail at runtime.
Replace the loose minLength constraint with the same regex pattern
used by the CLI: ^[0-9a-fA-F]{40}$|^[0-9a-fA-F]{64}$. Update all
test fixtures in review-result-label-actions-test.sh and
validate-output-schema-test.sh that used 7-character SHAs to use
valid 40-character hex strings.
Closes #5669
|
🤖 Finished Review · ✅ Success · Started 12:04 PM UTC · Completed 12:16 PM UTC |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
ReviewFindingsLow
Labels: PR modifies harness validation schema and associated tests |
![fullsend-ai-review[bot]](https://avatars.githubusercontent.com/in/3478501?s=60&v=4){kind=small}
fullsend-ai-review
Bot
added
ready-for-merge
Member
|
This change does not belong here. Closing. |
|
🤖 Finished Retro · ✅ Success · Started 12:01 PM UTC · Completed 12:21 PM UTC |
Retro: PR #5674 — Wrong-Repo PR Due to Cross-Repo Path MismatchTimeline
Key FindingThe retro correctly chose the target repo but used file paths from the analyzed repo. The test file Evidence for Existing Issues
The Proposals filed
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Aligns the
head_shavalidation inreview-result.schema.jsonwith the CLI's runtime regex (hexSHAReinpostreview.go). The schema previously usedminLength: 7, which accepted short or non-hex strings that the CLI would then reject at runtime — causing agent fix iterations.Related Issue
Fixes fullsend-ai/agents#621
Changes
{ "type": "string", "minLength": 7 }with{ "type": "string", "pattern": "^[0-9a-fA-F]{40}$|^[0-9a-fA-F]{64}$" }inreview-result.schema.json"abc1234") inreview-result-label-actions-test.shto valid 40-character hex stringsvalidate-output-schema-test.shreview-result tests to valid 40-character hex stringsTesting
review-result-label-actions-test.sh— all 8 tests passvalidate-output-schema-test.sh— all review-result tests pass (pre-existing triage-schema infra failures unrelated to this change)go test ./internal/scaffold/...passesCloses fullsend-ai/agents#621
Post-script verification
agent/5669-tighten-head-sha-schema)a3dd597c77dc90dc183f844b5aa9badea57a7bd4..HEAD)