Skip to content

ci(#5503): increase dispatch detection window to 4 minutes #5506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ifireball merged 1 commit into from
Jul 23, 2026
Merged

ci(#5503): increase dispatch detection window to 4 minutes #5506

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/behaviourtest/drivers/ci/githubactions/githubactions.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ const (
pollInterval = 15 * time.Second
dispatchWait = 12 * time.Minute
dispatchPoll = 5 * time.Second
dispatchMaxTry = 24
dispatchMaxTry = 48

artifactRunPoll = 5 * time.Second
artifactRunWait = 5 * time.Minute
Expand Down
11 changes: 11 additions & 0 deletions pkg/behaviourtest/drivers/ci/githubactions/githubactions_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,17 @@ import (
"github.com/fullsend-ai/fullsend/internal/forge"
)

func TestDispatchDetectionWindow_AtLeast4Minutes(t *testing.T) {
t.Parallel()

// The dispatch detection window is dispatchMaxTry × dispatchPoll.
// It must be at least 4 minutes to tolerate slow GitHub webhook
// delivery. See issue #5503.
window := time.Duration(dispatchMaxTry) * dispatchPoll
assert.GreaterOrEqual(t, window, 4*time.Minute,
"dispatch detection window (%v) should be at least 4 minutes", window)
}

func TestSelectWorkflowRun_ReturnsFailedRun(t *testing.T) {
t.Parallel()

Expand Down
Loading