test(#5494): fold fork-PR issue-harness negative into fork-label positive - #5501
Merged
Conversation
…tive
Register an issue-only harness ("fork-issue-ping") in the fork-label
positive scenario and assert it did not run, replacing the standalone
"Fork PR does not trigger issue-only harness" scenario. This removes
one ~90s settle wait by piggybacking the negative assertion on the
existing fork PR + label dispatch round-trip.
Note: pre-commit could not run in sandbox (network access denied).
The post-script runs an authoritative pre-commit check.
Unrelated test failures in internal/binary, internal/cli, and
internal/fetch are pre-existing (sandbox network restrictions).
All behaviourtest package tests pass.
Closes #5494
|
🤖 Finished Review · ✅ Success · Started 4:59 AM UTC · Completed 5:08 AM UTC |
Site previewPreview: https://85f9a80b-site.fullsend-ai.workers.dev Commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Looks good to me Labels: PR refactors e2e fork-dispatch behaviour tests (component/e2e + component/dispatch) as a maintenance chore (type/chore). |
![fullsend-ai-review[bot]](https://avatars.githubusercontent.com/in/3478501?s=60&v=4){kind=small}
fullsend-ai-review
Bot
added
ready-for-merge
ifireball
added
the
ok-to-test
ifireball
approved these changes
Jul 23, 2026
|
🤖 Finished Retro · ✅ Success · Started 6:37 AM UTC · Completed 6:51 AM UTC |
Retro: PR #5501 — test(#5494): fold fork-PR issue-harness negative into fork-label positiveWorkflow went well — no proposals filed. This retro covers a clean, zero-rework agent workflow on PR #5501, a code-agent-authored e2e test consolidation chore (part of epic #5490). Timeline
AssessmentWhat went well:
Why no proposals:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fold the standalone "Fork PR does not trigger issue-only harness" negative scenario into the existing "Fork PR label dispatches harness" positive scenario, eliminating a ~90s settle wait while maintaining the same test coverage.
Related Issue
Part of #5490.
Changes
fork-issue-ping) with an issue-only trigger (event.entity.kind == "work_item") in the fork-label positive scenarioTesting
make lint— pre-commit could not run in sandbox (network); post-script runs authoritative checkmake go-teston./pkg/behaviourtest/...— all tests passgo vet ./pkg/behaviourtest/...— cleanChecklist
!for breaking changes)Closes #5494
Post-script verification
agent/5494-fold-fork-issue-negative)c9c7540c2995d9a294ede00c2444d2eb600e4852..HEAD)