test(#5491): merge triage sufficient + sandbox URL-block scenarios - #5499
Merged
Conversation
Combine two triage scenarios that each paid a full GHA workflow wait into a single scenario with a combined dummy table. The merged scenario performs a disallowed url_get (expect fail) and writes the sufficient triage fixture (expect succeed), then asserts all three outcomes after a single workflow wait: URL op failure, fixture op success, and ready-to-code label presence. Pre-commit could not run in sandbox (network restriction). Closes #5491
|
🤖 Finished Review · ✅ Success · Started 4:55 AM UTC · Completed 5:01 AM UTC |
Site previewPreview: https://ab27131c-site.fullsend-ai.workers.dev Commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Looks good to me |
ifireball
approved these changes
Jul 23, 2026
5 tasks
|
🤖 Finished Retro · ✅ Success · Started 6:05 AM UTC · Completed 6:14 AM UTC |
Retro: PR #5499 — merge triage sufficient + sandbox URL-block scenariosVerdict: clean workflow, no new proposals. All improvement angles are already tracked by existing open issues. Timeline
Total wall-clock: ~88 min. Agent execution: ~22 min. Agent cost: ~$3.82. Rework cycles: 0. What went well
Evidence for existing issues (no new proposals needed)
|
This was referenced Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Merge two triage behaviour scenarios that each paid a full GHA workflow wait into a single scenario with a combined dummy table, halving the wall-clock cost of triage behaviour testing.
Related Issue
Closes #5491 (part of #5490 — fewer positive GHA round-trips for the behaviour suite).
Changes
e2e/behaviour/features/triage/triage.featureurl_get(expect fail) then writes the sufficient triage fixture (expect succeed)ready-to-codelabel presenceTesting
go build -tags behaviour ./e2e/behaviour/...passesgo vet ./pkg/behaviourtest/...passesgo test ./pkg/behaviourtest/...passesChecklist
Closes #5491
Post-script verification
agent/5491-merge-triage-scenarios)c9c7540c2995d9a294ede00c2444d2eb600e4852..HEAD)