Skip to content

test(#5493): fold PR-to-issue negative into PR-label positive scenario #5498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ifireball merged 2 commits into from
Jul 23, 2026
Merged

test(#5493): fold PR-to-issue negative into PR-label positive scenario #5498

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3fcdc42
test(#5493): fold PR-to-issue negative into PR-label positive scenario
fullsend-ai-coder[bot] Jul 23, 2026
034f846
ci(e2e): raise behaviour job timeout to 45m
ifireball Jul 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/e2e.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ jobs:
!cancelled() &&
(github.event_name != 'pull_request_target' || needs.gate.outputs.authorized == 'true')
runs-on: ubuntu-24.04
timeout-minutes: 30
timeout-minutes: 45
Comment thread
ifireball marked this conversation as resolved.
Resolved
Comment thread
ifireball marked this conversation as resolved.
Resolved
permissions:
contents: read
id-token: write
Expand Down
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ e2e-test:
go test -tags e2e -v -count=1 -timeout 30m ./e2e/admin/

behaviour-test:
go test -tags behaviour -v -count=1 -timeout 30m ./e2e/behaviour/
go test -tags behaviour -v -count=1 -timeout 45m ./e2e/behaviour/

# Functional agent evals — run agents against ephemeral GitHub repos and judge results.
# Required env: EVAL_ORG (GitHub org for ephemeral repos), plus GCP creds for Vertex AI.
Expand Down
22 changes: 10 additions & 12 deletions e2e/behaviour/features/dispatch/dispatch.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,32 +32,28 @@ Feature: Harness CEL dispatch
And the agent will succeed to Prove execution
And the harness "issue-ping" was dispatched exactly 1 time

Scenario: PR does not trigger issue-only harness
Given a custom harness "issue-ping" with:
Scenario: PR label dispatches PR-only harness but not issue-only harness
Given a custom harness "pr-ping" with:
"""
agent: agents/triage.md
role: triage
slug: fullsend-ai-issue-ping
slug: fullsend-ai-pr-ping
model: opus
image: ghcr.io/fullsend-ai/fullsend-sandbox:latest
trigger: |
event.entity.kind == "work_item"
event.entity.kind == "change_proposal"
&& event.transition.kind == "label_changed"
&& event.transition.label.name == "ready-for-ping"
&& event.transition.label.name == "ready-for-pr-ping"
"""
When a pull request is opened
Then the harness "issue-ping" agent did not run

Scenario: PR label dispatches PR-only harness
Given a custom harness "pr-ping" with:
And a custom harness "issue-only-ping" with:
"""
agent: agents/triage.md
role: triage
slug: fullsend-ai-pr-ping
slug: fullsend-ai-issue-only-ping
model: opus
image: ghcr.io/fullsend-ai/fullsend-sandbox:latest
trigger: |
event.entity.kind == "change_proposal"
event.entity.kind == "work_item"
&& event.transition.kind == "label_changed"
&& event.transition.label.name == "ready-for-pr-ping"
"""
Expand All @@ -69,6 +65,8 @@ Feature: Harness CEL dispatch
And the pull request is labeled "ready-for-pr-ping"
Then the harness "pr-ping" workflow completes successfully
And the agent will succeed to Prove PR execution
And the harness "pr-ping" was dispatched exactly 1 time
And the harness "issue-only-ping" agent did not run

Scenario: Disabled harness is not dispatched while enabled one triggers
Given a custom harness "enabled-ping" with:
Expand Down
Loading