Skip to content

fix(#5241): add missing --file flag to ImportProfile openshell command #5245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waynesun09 merged 1 commit into from
Jul 18, 2026
Merged

fix(#5241): add missing --file flag to ImportProfile openshell command #5245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/sandbox/sandbox.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ func ImportProfile(ctx context.Context, id, profilePath string) error {

importCtx, importCancel := context.WithTimeout(ctx, providerTimeout)
defer importCancel()
cmd := exec.CommandContext(importCtx, "openshell", "provider", "profile", "import", profilePath)
cmd := exec.CommandContext(importCtx, "openshell", "provider", "profile", "import", "--file", profilePath)
out, err := cmd.CombinedOutput()
if err != nil {
outStr := strings.ToLower(string(out))
Expand Down
24 changes: 24 additions & 0 deletions internal/sandbox/sandbox_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -675,6 +675,30 @@ exit 0
assert.NoError(t, err)
}

func TestImportProfile_UsesFileFlag(t *testing.T) {
dir := t.TempDir()
argsFile := filepath.Join(dir, "args.log")

// Fake openshell that logs args on "import" invocations and exits 0.
script := `#!/bin/sh
if [ "$3" = "import" ]; then
echo "$@" >> ` + argsFile + `
fi
exit 0
`
fakePath := filepath.Join(dir, "openshell")
require.NoError(t, os.WriteFile(fakePath, []byte(script), 0o755))
t.Setenv("PATH", dir)

err := ImportProfile(context.Background(), "my-profile", "/some/my-profile.yaml")
require.NoError(t, err)

logged, err := os.ReadFile(argsFile)
require.NoError(t, err)
assert.Contains(t, string(logged), "--file /some/my-profile.yaml",
"ImportProfile must pass --file flag to openshell provider profile import")
}

func TestImportProfile_AlreadyExists(t *testing.T) {
dir := t.TempDir()

Expand Down
Loading