Skip to content

chore: update fullsend shim workflow - #5198

Merged
rh-hemartin merged 1 commit into
mainfrom
fullsend/onboard
Jul 17, 2026
Merged

chore: update fullsend shim workflow#5198
rh-hemartin merged 1 commit into
mainfrom
fullsend/onboard

Conversation

@fullsend-ai-fullsend

Copy link
Copy Markdown
Contributor

This PR updates the fullsend shim workflow to match the current template in the .fullsend config repo.

The shim content has drifted from the template — this brings it back in sync.

@fullsend-ai-fullsend
fullsend-ai-fullsend Bot requested a review from a team as a code owner July 16, 2026 14:57
@github-actions

Copy link
Copy Markdown

E2E tests did not run

E2E tests run automatically for org/repo members and collaborators on pull requests.

For other contributors, a maintainer must add the ok-to-test label after the latest push.

See E2E testing guide for details.

@github-actions

github-actions Bot commented Jul 16, 2026

Copy link
Copy Markdown

Site preview

Preview: https://6c774600-site.fullsend-ai.workers.dev

Commit: cbab09ae2c98d36431399418651673e96cd91454

@codecov

codecov Bot commented Jul 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Update the shim workflow to match the current template
in the .fullsend config repo.
@rh-hemartin
rh-hemartin added this pull request to the merge queue Jul 17, 2026
Merged via the queue into main with commit 1fae933 Jul 17, 2026
16 checks passed
@rh-hemartin
rh-hemartin deleted the fullsend/onboard branch July 17, 2026 06:23
@fullsend-ai-retro

fullsend-ai-retro Bot commented Jul 17, 2026

Copy link
Copy Markdown

🤖 Finished Retro · ✅ Success · Started 6:25 AM UTC · Completed 6:37 AM UTC
Commit: cbab09a · View workflow run →

@fullsend-ai-retro

Copy link
Copy Markdown

Retro: PR #5198chore: update fullsend shim workflow

PR #5198 was an automated shim reconciliation PR from the fullsend/onboard branch, created by the reconcile-repos.sh script to update the fullsend shim workflow (.github/workflows/fullsend.yaml) in the platform repo itself. It was merged by a maintainer on 2026-07-17.

The retro agent was triggered automatically on PR close per the unconditional closed → retro routing in dispatch.yml (line 213). However, this class of PR — machine-generated, single-file shim updates — has no meaningful agent workflow to retrospect: no code agent, no review iteration, no rework cycle.

Key findings:

  1. Wasted retro compute on reconciliation PRs. The dispatch workflow unconditionally triggers retro on every PR close, including automated reconciliation PRs from fullsend/onboard and fullsend/offboard branches. These PRs have no agent workflow graph to analyze, making the retro a pure token cost with no value.

  2. No pre-flight API validation in retro pre-script. The pre-retro.sh script validates ORIGINATING_URL format but does not verify that GH_TOKEN provides working API access. The retro agent's core function — reconstructing the workflow graph — requires GitHub API access. When the token is invalid, the agent burns its entire timeout exploring dead ends.

Proposals filed

  1. Skip retro dispatch on automated reconciliation PRs
  2. Add GH_TOKEN pre-flight check to retro pre-script

Proposals filed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant