docs(#4531): correct comment references from EnsureAvailable to CheckGateway - #4533
Conversation
…Gateway Update three comments introduced in PR #2986 that incorrectly reference sandbox.EnsureAvailable as the failure point for the useFakeOpenshell stub. The stub is found by exec.LookPath in EnsureAvailable (which succeeds), but the actual test failure occurs at sandbox.CheckGateway, which runs "openshell gateway list" and gets exit code 1 from the stub. Changed locations: - useFakeOpenshell docstring in run_test.go - TestRunAgent_HarnessLoadPipeline comment in run_test.go - testdata/openshell stub file comment Closes #4531
E2E tests are runningAuthorization passed for this commit. See the E2E Tests workflow for results. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
/fs-review |
|
🤖 Finished Review · ✅ Success · Started 5:06 PM UTC · Completed 5:12 PM UTC |
|
Looks good to me Labels: Comment-only correction of sandbox function references in CLI test files. |
|
🤖 Finished Retro · ✅ Success · Started 7:14 AM UTC · Completed 7:27 AM UTC |
Retro: PR #4533 — correct comment references from EnsureAvailable to CheckGatewayTimeline
AssessmentWhat went well: The retro→code→review pipeline worked correctly end-to-end. The code agent's fix was precise — it updated exactly the 3 comments specified in the issue, correctly changing What could go better:
Skipped proposals
Proposals filed
|
The annotation on line 147 incorrectly attributed the EnsureGateway to CheckGateway rename to PR fullsend-ai#4533, which only updated test comments. Replace the specific (and wrong) PR reference with a general "since renamed" phrasing, since the actual rename PR is not identified. Closes fullsend-ai#4719
Update three comments introduced in PR #2986 that incorrectly reference sandbox.EnsureAvailable as the failure point for the useFakeOpenshell stub. The stub is found by exec.LookPath in EnsureAvailable (which succeeds), but the actual test failure occurs at sandbox.CheckGateway, which runs "openshell gateway list" and gets exit code 1 from the stub.
Changed locations:
Closes #4531
Post-script verification
agent/4531-fix-comment-checkgateway)f398c1f4eabdb445f2e8edccc6cffca3db7ed907..HEAD)