Skip to content

docs(#4531): correct comment references from EnsureAvailable to CheckGateway - #4533

Merged
rh-hemartin merged 1 commit into
mainfrom
agent/4531-fix-comment-checkgateway
Jul 14, 2026
Merged

docs(#4531): correct comment references from EnsureAvailable to CheckGateway#4533
rh-hemartin merged 1 commit into
mainfrom
agent/4531-fix-comment-checkgateway

Conversation

@fullsend-ai-coder

Copy link
Copy Markdown
Contributor

Update three comments introduced in PR #2986 that incorrectly reference sandbox.EnsureAvailable as the failure point for the useFakeOpenshell stub. The stub is found by exec.LookPath in EnsureAvailable (which succeeds), but the actual test failure occurs at sandbox.CheckGateway, which runs "openshell gateway list" and gets exit code 1 from the stub.

Changed locations:

  • useFakeOpenshell docstring in run_test.go
  • TestRunAgent_HarnessLoadPipeline comment in run_test.go
  • testdata/openshell stub file comment

Closes #4531

Post-script verification

  • Branch is not main/master (agent/4531-fix-comment-checkgateway)
  • Secret scan passed (gitleaks — f398c1f4eabdb445f2e8edccc6cffca3db7ed907..HEAD)
  • Pre-commit hooks passed (authoritative run on runner)
  • Tests ran inside sandbox

…Gateway

Update three comments introduced in PR #2986 that incorrectly
reference sandbox.EnsureAvailable as the failure point for the
useFakeOpenshell stub. The stub is found by exec.LookPath in
EnsureAvailable (which succeeds), but the actual test failure
occurs at sandbox.CheckGateway, which runs "openshell gateway
list" and gets exit code 1 from the stub.

Changed locations:
- useFakeOpenshell docstring in run_test.go
- TestRunAgent_HarnessLoadPipeline comment in run_test.go
- testdata/openshell stub file comment

Closes #4531
@fullsend-ai-coder
fullsend-ai-coder Bot requested a review from a team as a code owner July 13, 2026 15:05
@fullsend-ai-coder fullsend-ai-coder Bot added the ready-for-review Triggers review agent dispatch label Jul 13, 2026
@github-actions

github-actions Bot commented Jul 13, 2026

Copy link
Copy Markdown

E2E tests are running

Authorization passed for this commit. See the E2E Tests workflow for results.

@codecov

codecov Bot commented Jul 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@ralphbean ralphbean added the ok-to-test Allow e2e CI to run after maintainer review (must be re-applied after each push) label Jul 13, 2026
@ralphbean

Copy link
Copy Markdown
Member

/fs-review

@fullsend-ai-review

fullsend-ai-review Bot commented Jul 13, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 5:06 PM UTC · Completed 5:12 PM UTC
Commit: bd28f41 · View workflow run →

@fullsend-ai-review

Copy link
Copy Markdown

Looks good to me


Labels: Comment-only correction of sandbox function references in CLI test files.

@fullsend-ai-review fullsend-ai-review Bot added ready-for-merge All reviewers approved — ready to merge documentation component/sandbox OpenShell sandbox environment labels Jul 13, 2026
@rh-hemartin
rh-hemartin added this pull request to the merge queue Jul 14, 2026
Merged via the queue into main with commit 1401da4 Jul 14, 2026
37 of 38 checks passed
@rh-hemartin
rh-hemartin deleted the agent/4531-fix-comment-checkgateway branch July 14, 2026 07:12
@fullsend-ai-retro

fullsend-ai-retro Bot commented Jul 14, 2026

Copy link
Copy Markdown

🤖 Finished Retro · ✅ Success · Started 7:14 AM UTC · Completed 7:27 AM UTC
Commit: bed0ce7 · View workflow run →

@fullsend-ai-retro

Copy link
Copy Markdown

Retro: PR #4533 — correct comment references from EnsureAvailable to CheckGateway

Timeline

  1. PR chore(test): mock openshell in TestRunAgent_* to prevent hangs #2986 merged Jul 13 14:38 UTC — added useFakeOpenshell(t) to prevent test hangs, but left inaccurate comments referencing sandbox.EnsureAvailable instead of sandbox.CheckGateway
  2. Retro agent on PR chore(test): mock openshell in TestRunAgent_* to prevent hangs #2986 identified the inaccuracy and created issue Fix inaccurate comments in run_test.go referencing sandbox.EnsureAvailable instead of sandbox.CheckGateway #4531 (with ready-to-code label)
  3. Code agent implemented the fix and opened PR docs(#4531): correct comment references from EnsureAvailable to CheckGateway #4533 at 15:05 UTC — 4 additions, 4 deletions across 2 files
  4. ready-for-review label applied at 15:05:50 UTC, but no automated review dispatched (known issue #3996)
  5. Human (ralphbean) manually triggered /fs-review at 17:05 UTC — 2 hours after PR creation
  6. Review agent approved at 17:12 UTC: "Looks good to me"
  7. Human (rh-hemartin) approved at 07:03 UTC next day, merged at 07:12 UTC

Assessment

What went well: The retro→code→review pipeline worked correctly end-to-end. The code agent's fix was precise — it updated exactly the 3 comments specified in the issue, correctly changing EnsureAvailable to CheckGateway. The review agent's approval was appropriate for a trivial comment-only change. Zero rework iterations needed.

What could go better:

  1. Review auto-trigger gap (existing issue): The ready-for-review label did not trigger an automated review, adding ~2 hours of latency until a human intervened with /fs-review. This is tracked by #3996, which documents that pull_request_target.types is missing labeled, so the label-based handoff from code→review never fires. PR docs(#4531): correct comment references from EnsureAvailable to CheckGateway #4533 is another data point confirming this pattern.

  2. Remaining stale function name references: The docs reference EnsureGateway() in 3 locations, but this function does not exist — the actual function is CheckGateway(). This is the same class of issue that Fix inaccurate comments in run_test.go referencing sandbox.EnsureAvailable instead of sandbox.CheckGateway #4531 addressed (stale sandbox function name references) and was not caught by either the code agent or the review agent. No existing issue covers this; proposing below.

Skipped proposals

Proposals filed

maruiz93 pushed a commit to maruiz93/fullsend that referenced this pull request Jul 14, 2026
The annotation on line 147 incorrectly attributed the
EnsureGateway to CheckGateway rename to PR fullsend-ai#4533, which
only updated test comments. Replace the specific (and
wrong) PR reference with a general "since renamed"
phrasing, since the actual rename PR is not identified.

Closes fullsend-ai#4719
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/sandbox OpenShell sandbox environment documentation ok-to-test Allow e2e CI to run after maintainer review (must be re-applied after each push) ready-for-merge All reviewers approved — ready to merge ready-for-review Triggers review agent dispatch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix inaccurate comments in run_test.go referencing sandbox.EnsureAvailable instead of sandbox.CheckGateway

2 participants