fix: remove ready-for-review label from post-code.sh - #393
Conversation
Site previewPreview: https://a1d64140-site.fullsend-ai.workers.dev Commit: |
![fullsend-ai-review[bot]](https://avatars.githubusercontent.com/in/3478501?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review: #393
Head SHA: 75bc5b4
Timestamp: 2026-04-23T21:00:00Z
Outcome: approve
Summary
Clean, well-scoped deletion that directly addresses the double-trigger bug described in #391. The change removes all three ready-for-review label operations from post-code.sh (label creation, label-on-edit for existing PRs, and --label on gh pr create). The pull_request_target:opened event in the shim workflow independently triggers dispatch-review, so automated review dispatch is unaffected. The ready-for-review label remains available for manual /review triggers by humans. No orphaned variables, no behavioral side effects beyond the intended fix.
Findings
No findings.
Footer
Outcome: approve
This review applies to SHA 75bc5b441e8a627e4bb23e7bb0a742089bd971b5. Any push to the PR head clears this review and requires a new evaluation.
ralphbean
left a comment
ralphbean
left a comment
There was a problem hiding this comment.
Review
The fix is correct — removing the ready-for-review label from post-code.sh eliminates the double-trigger of dispatch-review. The pull_request_target:synchronize event covers the existing-PR re-trigger case, so no review dispatch is lost.
Two items to address:
- Stale docs (request changes): Several docs still describe the code agent applying the
ready-for-reviewlabel — these should be updated in this PR. - Label creation gap (note): The
gh label createcall was removed. The label should be created during repo scaffolding instead — tracked for a follow-up.
| # --------------------------------------------------------------------------- | ||
| export GH_TOKEN="${PUSH_TOKEN}" | ||
|
|
||
| PR_LABEL="ready-for-review" |
There was a problem hiding this comment.
The ready-for-review label creation (gh label create) was removed here. This means the label won't be pre-created with its description and color for repos that haven't seen a code agent run before the old version. Consider ensuring the label is created during repo scaffolding/installation instead. (Deferring to a follow-up is fine.)
|
Stale documentation: The following docs still describe the code agent applying the
The handoff now happens implicitly via |
|
Who is the reponsible for this PR? @waynesun09 @ralphbean ? |
The code agent's PR creation flow fired two events that both matched dispatch-review: pull_request_target:opened from gh pr create, and issues:labeled from the subsequent gh pr edit --add-label. This caused a redundant workflow dispatch that wasted compute and a GitHub App token. Remove the ready-for-review label addition from post-code.sh entirely: - Remove PR_LABEL variable and gh label create call - Remove gh pr edit --add-label for existing PRs - Remove --label flag from gh pr create for new PRs The pull_request_target:opened event already triggers dispatch-review for automated PR creation. The ready-for-review label remains available for manual /review triggers by humans. Note: make lint could not run (pre-commit network error in sandbox). Go tests could not run (go not available in sandbox). The change is a shell script deletion only — no Go code was modified. Closes #391
…ispatch The code agent no longer applies the ready-for-review label. Review dispatch is now triggered by pull_request_target events (PR opened, synchronize, ready_for_review) rather than explicit labeling. Update bugfix-workflow.md, ADR 0002, and architecture.md to reflect this. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2b3b7ab to
e9a2c64
Compare
Review: #393Head SHA: e9a2c64 SummaryThis PR correctly eliminates the double-dispatch bug described in #391. The FindingsNo critical, high, medium, low, or info findings. Correctness: The shell script deletions are clean — no dangling references to Intent alignment: The change matches issue #391 exactly (Option A). Documentation updates are in scope — they describe the behavioral change accurately. Platform security: No token handling changes. No new permissions or capabilities introduced. The Content security: No user content handling changes. Injection defense: PR body, commit messages, and code comments inspected — no prompt injection patterns, non-rendering Unicode, or suspicious directives found. Style/conventions: Shell script changes follow existing patterns. Documentation updates are consistent with the surrounding prose style. FooterOutcome: approve Previous runReview: automated reviewOutcome: failure The review agent reviewed commit |
ralphbean
left a comment
ralphbean
left a comment
There was a problem hiding this comment.
Review feedback addressed — docs updated to reflect pull_request_target-based review dispatch.
2 participants
The code agent's PR creation flow fired two events that both matched dispatch-review: pull_request_target:opened from gh pr create, and issues:labeled from the subsequent gh pr edit --add-label. This caused a redundant workflow dispatch that wasted compute and a GitHub App token.
Remove the ready-for-review label addition from post-code.sh entirely:
The pull_request_target:opened event already triggers dispatch-review for automated PR creation. The ready-for-review label remains available for manual /review triggers by humans.
Note: make lint could not run (pre-commit network error in sandbox). Go tests could not run (go not available in sandbox). The change is a shell script deletion only — no Go code was modified.
Closes #391
Changed files
internal/scaffold/fullsend-repo/scripts/post-code.shCloses #391
Post-script verification
agent/391-remove-double-trigger-label)7e5a9400d9813c304cc20bb1f41750b2549dad1e..HEAD)Created by fullsend code agent