Skip to content

fix(sandbox): force executable bit on host_files copied into bin/ #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ascerra merged 2 commits into from
Apr 23, 2026
Merged

fix(sandbox): force executable bit on host_files copied into bin/ #343

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c8149d
fix(sandbox): force executable bit on host_files copied into bin/
ralphbean Apr 22, 2026
b5089b9
Fix issue reference
ralphbean Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions internal/cli/run.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -651,6 +651,18 @@ func bootstrapEnv(sshConfigPath, sandboxName, repoDir string, h *harness.Harness
return fmt.Errorf("copying host file %s to %s: %w", hf.Src, hf.Dest, err)
}
}

// TODO(#312): remove this once admin install preserves the executable
Comment thread
ralphbean marked this conversation as resolved.
Resolved
// bit when writing files to .fullsend/. The GitHub Contents API commits
// everything as 100644, so scripts lose +x. Force it back for anything
// landing in a bin/ directory.
// https://github.com/fullsend-ai/fullsend/issues/312#issuecomment-4300729520
Comment thread
ralphbean marked this conversation as resolved.
Resolved
if strings.Contains(hf.Dest, "/bin/") {
chmodCmd := fmt.Sprintf("chmod +x %s", hf.Dest)
if _, _, _, sshErr := sandbox.SSH(sshConfigPath, sandboxName, chmodCmd, 10*time.Second); sshErr != nil {
return fmt.Errorf("chmod host file %s in sandbox: %w", hf.Dest, sshErr)
}
}
}

return nil
Expand Down
Loading