Skip to content

docs(agents): use precise terminology for action.yml heading - #3286

Merged
ralphbean merged 1 commit into
mainfrom
agent/3282-fix-action-workflows-terminology
Jul 7, 2026
Merged

docs(agents): use precise terminology for action.yml heading#3286
ralphbean merged 1 commit into
mainfrom
agent/3282-fix-action-workflows-terminology

Conversation

@fullsend-ai-coder

Copy link
Copy Markdown
Contributor

Summary

  • Rename the bold heading on AGENTS.md line 94 from "Action workflows (action.yml)" to "Composite action (action.yml)"
  • In GitHub Actions, "workflows" refers to .github/workflows/*.yml files, while action.yml defines a composite action
  • The old heading introduced the same class of terminological ambiguity that the repo's "Terminology: tier conventions" section exists to prevent

Closes #3282

Test plan

  • Verified AGENTS.md passes pre-commit lint checks
  • Verified no cross-references to the old heading text exist elsewhere in the repo
  • Confirmed CLAUDE.md and other docs do not reference the old heading

…eading

Rename "Action workflows" to "Composite action" in the forge abstraction
section. In GitHub Actions, "workflows" refers to .github/workflows/*.yml
files, while action.yml defines a composite action. The old heading
introduced the same class of terminological ambiguity that the repo's
Terminology section was created to prevent.

Closes #3282

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@fullsend-ai-coder
fullsend-ai-coder Bot requested a review from a team as a code owner July 7, 2026 10:20
@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown

E2E tests did not run

E2E tests run automatically for org/repo members and collaborators on pull requests.

For other contributors, a maintainer must add the ok-to-test label after the latest push.

See E2E testing guide for details.

1 similar comment
@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown

E2E tests did not run

E2E tests run automatically for org/repo members and collaborators on pull requests.

For other contributors, a maintainer must add the ok-to-test label after the latest push.

See E2E testing guide for details.

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown

Site preview

Preview: https://df552c96-site.fullsend-ai.workers.dev

Commit: bc3652e776ed2e3de1adcfe550d8d085fcd6d263

@codecov

codecov Bot commented Jul 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@ralphbean
ralphbean added this pull request to the merge queue Jul 7, 2026
Merged via the queue into main with commit a188f6d Jul 7, 2026
17 checks passed
@ralphbean
ralphbean deleted the agent/3282-fix-action-workflows-terminology branch July 7, 2026 22:45
@fullsend-ai-retro

fullsend-ai-retro Bot commented Jul 7, 2026

Copy link
Copy Markdown

🤖 Finished Retro · ✅ Success · Started 10:47 PM UTC · Completed 11:00 PM UTC
Commit: bc3652e · View workflow run →

@fullsend-ai-retro

Copy link
Copy Markdown

PR #3286 was a clean, well-executed 1-line terminology fix that renamed the "Action workflows (action.yml)" heading to "Composite action (action.yml)" in AGENTS.md. The code agent produced a single commit with zero rework. The retro→code pipeline worked correctly end-to-end: the retro agent on PR #2219 caught an unaddressed info-level review finding about ambiguous GitHub Actions terminology → filed issue #3282 → code agent created PR #3286 → ralphbean approved → merged same day.

Two inefficiencies stand out:

  1. Multi-hop feedback loop for a 1-word change: The review agent on PR docs(#2215): extend forge abstraction scope to action.yml #2219 correctly flagged the terminology issue as [info] severity. Human reviewers approved without addressing it. The retro then had to catch it post-merge, spinning up the full pipeline (retro analysis + issue creation + code agent PR + human review + CI). Total overhead: 3+ agent runs, ~12 hours latency, for what could have been addressed inline during PR docs(#2215): extend forge abstraction scope to action.yml #2219's review cycle.

  2. No review agent ran on PR docs(agents): use precise terminology for action.yml heading #3286: The dispatch job completed in 7 seconds with the 'Determine stage' step producing no stage — all subsequent steps were skipped. This confirms the bot authorization gap tracked in #2674: is_event_actor_authorized("fullsend-ai-coder[bot]") fails because GitHub App bots aren't collaborators. PR docs(agents): use precise terminology for action.yml heading #3286 modified AGENTS.md (a protected governance file) with zero automated review. This is the same pattern documented in dispatch: ADR 0054 authorization gate blocks review dispatch for coder-bot PRs #2674 and Prioritize review dispatch for bot-authored PRs that modify agent definitions #2988.

Existing issue coverage for patterns observed:

One novel proposal below addresses the severity rating gap that caused the multi-hop feedback loop.

Proposals filed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix 'Action workflows' terminology in AGENTS.md forge abstraction section

1 participant