fix: mask GCP credential paths and migrate app-id to client-id - #318
Merged
Conversation
The google-github-actions/auth action exposes credential file paths (GOOGLE_GHA_CREDS_PATH, GOOGLE_APPLICATION_CREDENTIALS, etc.) in job logs. Add ::add-mask:: steps after GCP auth in all agent workflows. Migrate from deprecated app-id input to client-id in actions/create-github-app-token@v3. This changes the stored variable from FULLSEND_<ROLE>_APP_ID (numeric) to FULLSEND_<ROLE>_CLIENT_ID (GitHub App Client ID string). Adds GetAppClientID to forge interface so existing app reuse can look up the Client ID. Existing installations need a re-run of fullsend admin install to create the new CLIENT_ID variables. Signed-off-by: Wayne Sun <gsun@redhat.com>
Site previewPreview: https://7aec77d9-site.fullsend-ai.workers.dev Commit: |
Signed-off-by: Wayne Sun <gsun@redhat.com>
Address review findings: - GetAppClientID now returns an error if the API response lacks a client_id field instead of silently returning an empty string - Add test for GetAppClientID error path in handleExistingApp - Add FakeClient.GetAppClientID tests (found, not found, error injection) - Update 7 docs (SPECs, ADRs, plans) from APP_ID to CLIENT_ID per GitHub's official recommendation to use Client ID as the canonical app identifier Signed-off-by: Wayne Sun <gsun@redhat.com>
rh-hemartin
approved these changes
Apr 22, 2026
ralphbean
approved these changes
Apr 22, 2026
7 tasks
9 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GOOGLE_GHA_CREDS_PATH,GOOGLE_APPLICATION_CREDENTIALS,CLOUDSDK_AUTH_CREDENTIAL_FILE_OVERRIDE) in all agent workflow logs using::add-mask::aftergoogle-github-actions/auth@v3app-idtoclient-idinput inactions/create-github-app-token@v3across all scaffold workflowsIv23_...string) instead of the numeric App ID, with a newGetAppClientIDforge method for existing app reuseMotivation
actions/create-github-app-token@v3.1.0deprecated theapp-idinput in favor ofclient-id(2026-04-11); the numeric App ID still works today but GitHub may stop accepting it as a JWT issuer in the futureBreaking changes
FULLSEND_<ROLE>_APP_ID→FULLSEND_<ROLE>_CLIENT_IDfullsend admin installto create the newCLIENT_IDvariables (not yet rolled out to production)Test plan
go vet ./...passesgo test ./...— all unit tests pass (layers, appsetup, forge, scaffold, cli)make lintpassesfullsend admin installon a test org to verify Client ID is stored correctly