docs: remove stale retro.env references from retro agent plan - #2946
docs: remove stale retro.env references from retro agent plan#2946sreedhards wants to merge 1 commit into
Conversation
E2E tests did not runE2E tests run automatically for org/repo members and collaborators on pull requests. For other contributors, a maintainer must add the See E2E testing guide for details. |
PR Summary by QodoDocs: remove retro.env references from retro agent plan
AI Description
Diagram
High-Level Assessment
Files changed (1)
|
Code Review by Qodo
1. Task file action mismatch
|
| **Files:** | ||
| - Create: `internal/scaffold/fullsend-repo/env/retro.env` | ||
| - Modify: `internal/scaffold/fullsend-repo/harness/retro.yaml` (see Task 8) |
There was a problem hiding this comment.
1. Task file action mismatch 🐞 Bug ≡ Correctness
Task 3 lists internal/scaffold/fullsend-repo/harness/retro.yaml as a file to modify, but Task 8 later instructs creating that same file, which conflicts with the plan’s sequential task flow. This can cause confusion for agents/humans following the checklist and looking for a file that doesn’t exist yet at Task 3 time.
Agent Prompt
## Issue description
Task 3 says to **modify** `internal/scaffold/fullsend-repo/harness/retro.yaml`, but Task 8 is where the plan actually **creates/writes** that file. This is internally inconsistent and can break the intended task-by-task execution order.
## Issue Context
The plan doc is meant to be executed sequentially using checkboxes. Referring to a file as “Modify” before it exists is confusing, even if it parenthetically points to Task 8.
## Fix Focus Areas
- docs/superpowers/plans/2026-05-04-retro-agent.md[180-192]
- docs/superpowers/plans/2026-05-04-retro-agent.md[637-646]
## Suggested fix
In **Task 3**, change the **Files** section to something like:
- (Option A) Remove the file entry entirely (since Task 3 is now guidance-only), or
- (Option B) Replace with: `- Configure in: internal/scaffold/fullsend-repo/harness/retro.yaml (created in Task 8)`
So Task 3 no longer implies an earlier modification of a not-yet-created file.
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
Fixes fullsend-ai#2939. Updates the retro agent implementation plan to reflect ADR 0055 env.runner/env.sandbox delivery instead of the removed per-harness env file and deprecated runner_env block. Signed-off-by: sreedhards <8810551+sreedhards@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
87484e1 to
f0253d8
Compare
|
Apologies to waste your time and tokens. Thank you for the PR, but - please see latest comments on #2939 |
|
🤖 Finished Retro · ✅ Success · Started 5:02 PM UTC · Completed 5:09 PM UTC |
|
PR #2946 was a docs-only PR opened by external contributor sreedhards to fix issue #2939 (stale retro.env references in a historical plan doc). The PR was closed without merging by maintainer ralphbean, who determined that updating historical plan documents is unnecessary work. The root cause is an agent cascade: the review agent on PR #2761 flagged stale references in the plan doc → the retro agent created issue #2939 proposing the fix → the triage agent confirmed it as a good first issue → the code agent attempted and failed → an external contributor picked it up and wasted their time. ralphbean explicitly asked for repo-specific guidance (e.g., AGENTS.md) so agents learn that plan docs under docs/superpowers/plans/ are historical artifacts that should not be updated. Issue #2678 (review agent should deprioritize findings on planning/design documents) is related but covers only the review agent dimension, not the retro or triage agents. Two proposals: (1) add repo-specific guidance in AGENTS.md about historical plan docs, and (2) add retro agent guidance to avoid proposing issues for stale references in historical documents. Proposals filed
|
Summary
env.runner/env.sandbox/forge.github.envconfigurationrunner_envandhost_filesenv delivery from the plan doc exampleFixes #2939
Test plan
grep -rn 'retro.env' docs/returns zero matchesinternal/scaffold/fullsend-repo/harness/retro.yamlpatternMade with Cursor