Skip to content

Add step timing and fix sandbox create blocking - #290

Merged
rh-hemartin merged 1 commit into
mainfrom
hemartin/step-timing-and-sandbox-fix
Apr 21, 2026
Merged

Add step timing and fix sandbox create blocking#290
rh-hemartin merged 1 commit into
mainfrom
hemartin/step-timing-and-sandbox-fix

Conversation

@rh-hemartin

Copy link
Copy Markdown
Member

Summary

  • Add elapsed-time display (seconds) to every CLI step message for better observability during fullsend run
  • Fix sandbox create blocking: replace timeout-wrapped interactive shell with -- true so the command returns immediately
  • Remove stale timeout exit-code handling that was working around the interactive shell issue

Test plan

  • Run fullsend run and verify each step shows elapsed time in parentheses
  • Verify sandbox creation no longer hangs waiting for interactive shell exit
  • Run make go-vet and make go-test

🤖 Generated with Claude Code

@github-actions

github-actions Bot commented Apr 21, 2026

Copy link
Copy Markdown

Site preview

Preview: https://b010503b-site.fullsend-ai.workers.dev

Commit: 0114e47c140920d1224d1ffe424a34d311461307

Show elapsed seconds on each CLI step for observability. Replace
timeout-wrapped interactive sandbox create with `-- true` so the
command returns immediately without requiring shell exit.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Hector Martinez <hemartin@redhat.com>
@rh-hemartin
rh-hemartin force-pushed the hemartin/step-timing-and-sandbox-fix branch from 8548291 to 0114e47 Compare April 21, 2026 11:44
@rh-hemartin
rh-hemartin added this pull request to the merge queue Apr 21, 2026
Merged via the queue into main with commit 9267a53 Apr 21, 2026
3 checks passed
@rh-hemartin
rh-hemartin deleted the hemartin/step-timing-and-sandbox-fix branch April 21, 2026 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants