Skip to content

fix(#2783): refresh OIDC token before agent start #2859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waynesun09 merged 1 commit into from
Jul 1, 2026
Merged

fix(#2783): refresh OIDC token before agent start #2859

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion internal/cli/run.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -921,7 +921,12 @@ func runAgent(ctx context.Context, agentName, fullsendDir, outputBase, targetRep
if err != nil {
printer.StepWarn("OIDC token refresh disabled: " + err.Error())
} else {
printer.StepDone("OIDC token refresh enabled (WIF mode)")
// GHA OIDC tokens expire after 5 min; sandbox setup can exceed that.
if err := refreshOIDCToken(oidcCtx, sandboxName, oidcURL, oidcAuth); err != nil {
printer.StepWarn("Initial OIDC refresh failed (will retry): " + err.Error())
} else {
printer.StepDone("OIDC token refreshed, background refresh enabled (WIF mode)")
}
Comment thread
qodo-code-review[bot] marked this conversation as resolved.
oidcWg.Add(1)
go func() {
defer oidcWg.Done()
Expand Down
2 changes: 1 addition & 1 deletion internal/scaffold/fullsend-repo/scripts/prepare-sandbox-credentials.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ set -euo pipefail
# endpoint, so this script pre-fetches the OIDC token and rewrites the config
# to use a file-based credential source instead.
#
# Note: the OIDC token expires after ~10 min. The fullsend CLI refreshes it
# Note: the OIDC token expires after ~5 min. The fullsend CLI refreshes it
# automatically using FULLSEND_GCP_OIDC_URL and FULLSEND_GCP_OIDC_AUTH_FILE
# exported below.
#
Expand Down
Loading